Repository navigation
chore(cli): remove obsolete mascot splash - #2197
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Xuepoo
left a comment
There was a problem hiding this comment.
Independent review — no actionable findings
Attribution: verdict carried from the CTX-1301 lane note PX-6737 ("Independent review found no actionable issues; targeted init/completion/unknown-flag tests pass"), recorded here by the guard tick because the PR carried no review comment (single GitHub identity cannot self-approve; comment-LGTM is the recorded merge-gate form).
Scope: PR #2197 head c3918733 — mascot splash removal + README streamlining. Files: README.md, crates/bitty-terminal/assets/mascot.txt (deleted), crates/bitty-terminal/src/{cli,completion,init,main,mascot,tests}.rs, crates/bitty-terminal/tests/cli_splash.rs.
Evidence (from CTX-1301 notes):
cargo fmt --all -- --check,git diff --checkclean.- targeted parser 46 passed; init_interactive_all_defaults passed; help/version passed; headless smoke passed; completion 6 passed;
just markdownlint0 issues;just actionlintpassed. - remote CI on head
c3918733: Quality gates (1)/(2), MSRV 1.85, Windows, macOS ARM64, Linux X11, Linux Wayland, Supply chain, Analyze (rust/actions), CodeQL, M1 + Compat aggregates, VM tier (PR) — all pass.
Note: the lane's local just check stopped only at an environmental cargo audit RustSec advisory DB TLS/EOF fetch, not a code/test failure; remote Supply chain (deny/audit) is green on the head SHA. PR is BEHIND main; merged via --admin (squash) as the only blocker.
Reviewed-by: separate-agent lane review (CTX-1301); recorded by guard tick.
Priority: P2 | Area: cli | Labels: chore, P2, area:cli | Milestone: v0.1.0 | RFC: OQ-036 | Task: CTX-1301
Summary
--no-splashflag from parsing, help, and shell completionsVerification
cargo fmt --all -- --checkgit diff --checkjust checkran withCARGO_BUILD_JOBS=2and externalBITTY_PERF_DIR; formatting, clippy, tests, and supply-chain checks progressed, but the gate stopped whencargo auditcould not fetch RustSec advisory data due to a network/TLS EOF. No code/test failure was reported.The full local gate blocker is environmental advisory-database download failure; remote CI is required for final acceptance.