Skip to content

chore(cli): remove obsolete mascot splash - #2197

Merged
Xuepoo merged 1 commit into
mainfrom
carryctx/ctx-1301
Oct 17, 2026
Merged

Xuepoo merged 1 commit into
mainfrom
carryctx/ctx-1301

Conversation

@Xuepoo

@Xuepoo Xuepoo commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Priority: P2 | Area: cli | Labels: chore, P2, area:cli | Milestone: v0.1.0 | RFC: OQ-036 | Task: CTX-1301

Summary

  • remove the obsolete bitty init mascot splash asset and startup module
  • remove the obsolete --no-splash flag from parsing, help, and shell completions
  • remove splash-only tests and helper code
  • streamline the root README and direct product presentation to https://bitty.run

Verification

  • independent review: no actionable findings
  • cargo fmt --all -- --check
  • git diff --check
  • init tests: 90 passed
  • completion tests: 9 passed
  • unknown-flag tests: 3 passed
  • just check ran with CARGO_BUILD_JOBS=2 and external BITTY_PERF_DIR; formatting, clippy, tests, and supply-chain checks progressed, but the gate stopped when cargo audit could not fetch RustSec advisory data due to a network/TLS EOF. No code/test failure was reported.

The full local gate blocker is environmental advisory-database download failure; remote CI is required for final acceptance.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2999d666-dc1c-452d-8352-76f81b3a33bd
📥 Commits

Reviewing files that changed from the base of the PR and between aceb327 and c391873.

📒 Files selected for processing: 9
  • README.md
  • crates/bitty-terminal/assets/mascot.txt
  • crates/bitty-terminal/src/cli.rs
  • crates/bitty-terminal/src/completion.rs
  • crates/bitty-terminal/src/init.rs
  • crates/bitty-terminal/src/main.rs
  • crates/bitty-terminal/src/mascot.rs
  • crates/bitty-terminal/src/tests.rs
  • crates/bitty-terminal/tests/cli_splash.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Xuepoo Xuepoo added chore Chore / maintenance P2 Priority: medium area:cli Area: command-line interface labels Oct 17, 2026
@Xuepoo Xuepoo added this to the v0.1.0 milestone Oct 17, 2026

@Xuepoo Xuepoo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review — no actionable findings

Attribution: verdict carried from the CTX-1301 lane note PX-6737 ("Independent review found no actionable issues; targeted init/completion/unknown-flag tests pass"), recorded here by the guard tick because the PR carried no review comment (single GitHub identity cannot self-approve; comment-LGTM is the recorded merge-gate form).

Scope: PR #2197 head c3918733 — mascot splash removal + README streamlining. Files: README.md, crates/bitty-terminal/assets/mascot.txt (deleted), crates/bitty-terminal/src/{cli,completion,init,main,mascot,tests}.rs, crates/bitty-terminal/tests/cli_splash.rs.

Evidence (from CTX-1301 notes):

  • cargo fmt --all -- --check, git diff --check clean.
  • targeted parser 46 passed; init_interactive_all_defaults passed; help/version passed; headless smoke passed; completion 6 passed; just markdownlint 0 issues; just actionlint passed.
  • remote CI on head c3918733: Quality gates (1)/(2), MSRV 1.85, Windows, macOS ARM64, Linux X11, Linux Wayland, Supply chain, Analyze (rust/actions), CodeQL, M1 + Compat aggregates, VM tier (PR) — all pass.

Note: the lane's local just check stopped only at an environmental cargo audit RustSec advisory DB TLS/EOF fetch, not a code/test failure; remote Supply chain (deny/audit) is green on the head SHA. PR is BEHIND main; merged via --admin (squash) as the only blocker.

Reviewed-by: separate-agent lane review (CTX-1301); recorded by guard tick.

@Xuepoo
Xuepoo merged commit b99059b into main Oct 17, 2026
17 checks passed
@Xuepoo
Xuepoo deleted the carryctx/ctx-1301 branch October 17, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:cli Area: command-line interface chore Chore / maintenance P2 Priority: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant