Repository navigation
[CTX-1227] feat: declare [settings] keys, user config honored (composer#18 follow-through) - #20
Merged
Merged
Conversation
…er#18 follow-through)
Xuepoo
added a commit
that referenced
this pull request
Oct 19, 2026
composer#23 reports activation aborting on Bitty 0.0.24 with `E_SETTINGS_UNDECLARED` for `newline`. The five declarations landed in `de75a3f` (PR #20); the runtime matrix installed `c9e94c4`, a stale pre-declaration branch, so main was already past the defect while the empty-settings and explicit-value activation paths were not pinned against the declared key set. Add `tests/settings-declarations.test.ts`: - the manifest `[settings]` key set must equal exactly the keys registration reads (`M.DEFAULT_KEYS` plus `open_chord`), derived from the entry point instead of a hand-maintained list; - declared kinds and shipped defaults must match the Lua fallbacks; - activation must succeed with an empty settings file and with no settings bridge values at all, routing the shipped default chords (Enter inserts, Ctrl+Enter submits); - explicit `newline`/`submit` values must be honored; - the declared-key model must stay closed, which is the shape the host turns into `E_SETTINGS_UNDECLARED`. Task: CTX-0010 Closes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority: P1 | Area: composer | Labels: feat,P1 | Milestone: v0.1.0 | Task: CTX-1227
Follow-through on #18 (already CLOSED; activation proven). #19 kept activation alive with a fail-to-default pcall guard because the pinned SDK (862e29e) rejected
[settings]asmanifest.unknown-key(tripwire test held the line). SDK#152 is now merged (bitty-plugin-sdk#f6fc2f7): the linter admits[settings]and MockHost enforces the declared-keys gate. This PR lands the declarations.Changes
[settings]: declares exactly the 5 keys init.lua reads —newline/submit/close/external_editor/open_chord, all{ type = "string", default = ... }with defaults mirroringM.DEFAULT_KEYS/M.DEFAULT_OPEN_CHORD(enter, ctrl+enter, escape, alt+e, alt+e). Verbatim the SDK#151 snippet; shapes per SDK#152 SettingDecl validation (key grammar, kind/default agreement, string bounds).862e29e->f6fc2f7(package.json + bun.lock) sojust manifestand the mock enforce the same contract as the host.settings.gettest still proves the guard.open_chord, open_err = parse(default)overwrote the original parse error with the default's nil error, so theKEYS_FALLBACKnote below was dead code — an invalid customopen_chordfell back silently while every other invalid chord records the diagnostic. Now keeps the original error; fallback chord still the shipped default. Found by the new invalid-open_chord test (red before, green after).Tests (tripwire removed, declarations-live suite)
manifest declares exactly the five settings keys init.lua reads: model-level (loadManifestModel) kinds + defaults match shipped values.wrong-typed stored values fail to defaults with no fallback(updated): mock serves defaults at read like the host;last_code"ok", default chords route.custom values are honored across all five keys: all four roles remapped end to end (newline/submit/close/editor routing) + valid custom open_chord leaves no fallback.an unparseable custom open_chord falls back with KEYS_FALLBACK+custom open_chord reaches the keymap suggestion(suggest-arg capture: ctrl+o honored, unset serves alt+e).undeclared keys stay denied with E_SETTINGS_UNDECLARED: get AND set outside the five fail closed; declared-unset serves defaults.just checkgreen (fmt, markdownlint, metadata, hygiene, paths, manifest 0 errors, lua, lua-control,bun test77 pass / 0 fail across 5 files).Do NOT merge (commander integrates after review + CI).