feat(models): preserve bulk across MagmaOcean fractional stages - #11
Merged
Conversation
…-aware extraction to pt_grid
bknight1
added
enhancement
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MagmaOcean.run_fractional_stagesnow preservesself.X(bulk composition) across stages viasaved_X/try/finally, preventing drift.starting_meltlength is validated against the bulk composition before any state mutation.find_temperature_at_vol_fracraisesRuntimeErroron bisection failure (was returning bracket endpoint silently).avg_meltis computed only over melt-bearing samples (was dividing by total pressure intervals, inflating average when melt was absent).total_solid == 0branch returns emptylayer_modes(was a division-by-zero risk).Depends on: #9 (refactor/instance-aware-extract-grid)
Test plan
python3 -m unittest tests/test_fractionation.py(3 MagmaOcean tests pass)python3 -m unittest discover tests(5 tests pass, 0 failures)