Allow hiding agent harness options by klopez4212 · Pull Request #2588 · block/buzz

klopez4212 · 2026-07-23T18:53:22Z

Summary

Add per-device Settings toggles for installed agent harnesses.
Hide disabled harnesses from every new runtime picker and provisioning path without uninstalling them or changing existing pinned/current configurations.
Keep implicit fallback selection and backend pinning consistent across dialogs, onboarding defaults, templates, quick drops, and mention-created agents.

Testing

Desktop static checks
Desktop unit tests (3,514 passed)
Onboarding browser regression for disabled ready harnesses
Full Rust and desktop Tauri unit suites via the pre-push gate (1,636 native desktop tests passed; 14 keychain-only tests ignored)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b365349c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b16014102a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a049a3383

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b48a8c2af1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0f26020cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2de493809

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33d285e543

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e82da3615

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93cf670e77

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9b164fbf4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 642fedcff0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wpfleger96 · 2026-07-23T23:38:13Z

hey @klopez4212 — consolidated review feedback as of 642fedcff. One important item, the rest are minor/nits (flagging everything for completeness, so weigh accordingly). The iteration on this branch has been good — the resolveVisibleDefaultRuntime fallback-order fix and the ?? bypass removal in 642fedcff both resolved things I'd drafted against earlier heads.

1. (important) Four implicit create surfaces still hand off an unpinned fallback, so the hidden harness can spawn anyway. resolvePersonaRuntime now resolves a visible fallback correctly, but for a runtime-less persona that selection doesn't survive the backend handoff:

AddChannelBotDialog.tsx sends harnessOverride: false explicitly
useApplyTemplate.ts (both loops), useQuickBotDrop.ts, and useMentionSendFlow.ts omit it, which defaults to false in channelAgents.ts

With harness_override: false and a linked persona, create_time_agent_command_override (discovery/overrides.rs) returns None — the visible runtime the UI chose is discarded, and spawn falls through record_agent_command → default_agent_command(), i.e. buzz-agent, which may be exactly the harness the user hid. AddTeamToChannelDialog and buildInstanceInputForDefinition already handle this via shouldPinSelectedRuntimeForDefinition; I think the other four surfaces need the same treatment (or ideally all persona-backed creates route through one shared input builder). A cross-boundary regression test would help too — runtime-less persona + hidden buzz-agent → the agent persists and spawns on the fallback from each surface. Resolver unit tests can't catch this since the bug lives in the frontend/backend handoff.

2. (minor) global_model_provider_for_record compares runtimes with std::ptr::eq — it works because both sides come from the static KNOWN_ACP_RUNTIMES table, but preferred.id == selected.id is equally cheap and won't silently break if a KnownAcpRuntime is ever constructed outside the table.

3. (minor) The relay-mesh hide policy now lives in two places: getPersonaHiddenProviderIds (agentConfigOptions.tsx) and the inline memo in AgentConfigFields.tsx, with subtly different inputs (selectable-set + preserveCurrentRuntime vs. bare selectedRuntimeId !== "buzz-agent"). The doc comment says "one source of truth" but there are two — worth collapsing.

4. (minor) When a pinned runtime is filtered out of the dropdown, the edit dialogs push `${id} (current)` using the raw id — "goose (current)" instead of "Goose (current)". The label is available in the unfiltered runtimes list.

5. (minor) useQuickBotDrop and useMentionSendFlow seed their fallback with runtimes[0], and resolveVisibleDefaultRuntime only applies the buzz-agent-first ordering when that seed is hidden — a visible runtimes[0] is returned as-is. Pre-existing behavior, but now inconsistent with the deliberate preference ordering elsewhere in this PR.

6. (nit) The PR description could use a refresh from the final state — the architecture evolved a lot over the nine commits (central resolvePersonaRuntime visibility boundary, the create-vs-edit configScope split, getPersonaHiddenProviderIds, create-mode seed replacement) and the current description doesn't cover it all.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 616e9d7625

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ess-toggles # Conflicts: # desktop/src/features/agents/AGENTS.md # desktop/src/features/agents/ui/AgentDefaultsEditor.tsx # desktop/src/features/agents/ui/AgentDefinitionDialog.tsx # desktop/src/features/agents/ui/AgentInstanceEditDialog.tsx

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8d8fb2848

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

wpfleger96 · 2026-07-24T15:50:31Z

Nit: (current) dropdown fallback shows raw runtime id instead of display label

Both edit dialogs push a fallback option when the agent's pinned runtime is not in the filtered selectable list, but use the raw id string rather than the human-readable label:

AgentDefinitionDialog.tsx (~line 572): label: `${runtime.trim()} (current)
AgentInstanceEditDialog.tsx (~line 232): label: `${selectedRuntimeId} (current)

This produces labels like "goose (current)" instead of "Goose (current)". The unfiltered runtimes list (which carries formatRuntimeOptionLabel-compatible entries) is in scope at both sites, so the fix is a straightforward lookup:

const currentLabel =
  runtimes.find((r) => r.id === runtime.trim())?.label ?? runtime.trim();
// label: `${currentLabel} (current)`

Not a blocker — the option functions correctly and the value is correct. Follow-up cleanup.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a50252ff6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ess-toggles

klopez4212 · 2026-07-24T17:02:38Z

🤖 @wpfleger96 Your consolidated feedback is addressed on the current head (4ad4ee7): implicit runtime-less creates now preserve the visible fallback through backend provisioning, runtime comparisons use stable IDs, provider visibility is centralized and catalog-driven, current-only options use display labels, quick-drop/mention paths share the normal fallback order, and the PR summary is refreshed. I also closed the remaining configuration-picker gap so disabled harnesses are excluded from onboarding defaults and channel-template choices while existing saved values remain valid. All desktop, Rust, and native pre-push suites pass.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ad4ee7ba4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 26ca6e0f53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ess-toggles # Conflicts: # desktop/src/features/settings/ui/DoctorSettingsPanel.tsx # desktop/tests/e2e/doctor-states.spec.ts

…ess-toggles

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f634af92c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb015bc761

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ess-toggles

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e70b78b59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ess-toggles

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44b276f542

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-25T03:28:40Z

+    if selected_runtime.is_some_and(|selected| {
+        preferred_runtime.is_some_and(|preferred| preferred.id == selected.id)
+    }) {


Preserve defaults for explicit harness overrides

When a runtime-less persona is provisioned with a deliberate harness override that differs from the global preferred runtime—for example, a channel template explicitly assigns Goose while Buzz Agent is preferred—both record.runtime and the persona runtime remain unset, so this comparison classifies the explicit pin as an implicit fallback and discards global model/provider defaults. useApplyTemplate does not persist the global provider and may omit the model, leaving the created agent unconfigured even though masking is intended only for implicit fallbacks; persist the selection's intent or another durable fallback marker instead of inferring it solely from a command mismatch.

AGENTS.md reference: desktop/src/features/agents/AGENTS.md:L93-L99

Useful? React with 👍 / 👎.

Allow hiding agent harness options

4b36534

klopez4212 marked this pull request as ready for review July 23, 2026 20:08

klopez4212 requested a review from a team as a code owner July 23, 2026 20:08

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/ui/AgentDefaultsEditor.tsx

Keep hidden harness defaults in sync

b160141

klopez4212 requested a review from wpfleger96 July 23, 2026 20:31

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/lib/runtimeVisibilityPreference.ts Outdated

Honor harness visibility for implicit starts

4a049a3

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/lib/runtimeVisibilityPreference.ts Outdated

Scope defaults to visible harness fallbacks

b48a8c2

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/ui/useManagedAgentActions.ts Outdated

Apply harness visibility to every agent start

c0f2602

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src-tauri/src/managed_agents/global_config/mod.rs Outdated

Comment thread desktop/src/features/agents/ui/AddTeamToChannelDialog.tsx

Preserve explicit hidden harness starts

d2de493

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/useGlobalAgentConfig.ts Outdated

Preserve hidden harness defaults when editing

33d285e

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/lib/instanceInputForDefinition.ts

Filter implicit runtime fallbacks centrally

4e82da3

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/ui/AgentDefinitionDialog.tsx

Comment thread desktop/src/features/agents/ui/agentConfigOptions.tsx Outdated

Scope hidden harness defaults by dialog mode

93cf670

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/lib/resolvePersonaRuntime.ts Outdated

Comment thread desktop/src/features/agents/ui/AgentDefinitionDialog.tsx

Fix hidden agent harness fallbacks

d9b164f

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/agents/lib/resolvePersonaRuntime.ts

Comment thread desktop/src/features/agents/ui/AgentDefinitionDialog.tsx

Block hidden harness provisioning bypasses

642fedc

chatgpt-codex-connector Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread desktop/src/features/channels/ui/AddChannelBotDialog.tsx Outdated

Comment thread desktop/src/features/channel-templates/useApplyTemplate.ts

Preserve visible harness fallbacks

616e9d7

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread desktop/src/features/agents/ui/agentConfigOptions.tsx Outdated

Comment thread desktop/src/features/agents/lib/resolvePersonaRuntime.ts

klopez4212 added 2 commits July 23, 2026 17:26

Complete hidden harness provisioning policy

bb5b033

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread desktop/src/features/agents/lib/instanceInputForDefinition.ts

klopez4212 added 2 commits July 23, 2026 18:00

Address harness visibility review feedback

4ba301d

Fix harness visibility smoke fixture

0a0fba2

Use harness labels for current options

5a50252

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx

klopez4212 added 2 commits July 24, 2026 09:54

Filter hidden harnesses from remaining pickers

87ebbf4

Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…

4ad4ee7

…ess-toggles

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread desktop/src/features/onboarding/welcomeKickoff.ts

Filter hidden runtimes from welcome readiness

26ca6e0

chatgpt-codex-connector Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread desktop/src/features/onboarding/welcomeGuide.ts Outdated

klopez4212 added 3 commits July 24, 2026 10:56

Preserve hidden Welcome runtime aliases

d9c2b08

Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…

f62fb40

…ess-toggles # Conflicts: # desktop/src/features/settings/ui/DoctorSettingsPanel.tsx # desktop/tests/e2e/doctor-states.spec.ts

Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…

1f634af

…ess-toggles

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread desktop/src/features/onboarding/welcomeKickoff.ts

Handle hidden runtimes during Welcome kickoff

eb015bc

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread desktop/src/features/onboarding/ui/DefaultConfigStep.tsx

klopez4212 added 2 commits July 24, 2026 19:39

Respect hidden harnesses during onboarding

c77ad4f

Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…

1e70b78

…ess-toggles

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Comment thread desktop/src/features/onboarding/welcomeKickoff.ts

Comment thread desktop/src/features/agents/lib/runtimeVisibilityPreference.ts

klopez4212 added 2 commits July 24, 2026 20:18

Align hidden harness fallback readiness

33a0a60

Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…

44b276f

…ess-toggles

chatgpt-codex-connector Bot reviewed Jul 25, 2026

View reviewed changes

Uh oh!

Conversation

klopez4212 commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

wpfleger96 commented Jul 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

klopez4212 commented Jul 23, 2026 •

edited

Loading