-
Notifications
You must be signed in to change notification settings - Fork 832
Allow hiding agent harness options #2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klopez4212
wants to merge
28
commits into
main
Choose a base branch
from
kennylopez-agent-harness-toggles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4b36534
Allow hiding agent harness options
klopez4212 b160141
Keep hidden harness defaults in sync
klopez4212 4a049a3
Honor harness visibility for implicit starts
klopez4212 b48a8c2
Scope defaults to visible harness fallbacks
klopez4212 c0f2602
Apply harness visibility to every agent start
klopez4212 d2de493
Preserve explicit hidden harness starts
klopez4212 33d285e
Preserve hidden harness defaults when editing
klopez4212 4e82da3
Filter implicit runtime fallbacks centrally
klopez4212 93cf670
Scope hidden harness defaults by dialog mode
klopez4212 d9b164f
Fix hidden agent harness fallbacks
klopez4212 642fedc
Block hidden harness provisioning bypasses
klopez4212 616e9d7
Preserve visible harness fallbacks
klopez4212 bb5b033
Complete hidden harness provisioning policy
klopez4212 b8d8fb2
Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…
klopez4212 4ba301d
Address harness visibility review feedback
klopez4212 0a0fba2
Fix harness visibility smoke fixture
klopez4212 5a50252
Use harness labels for current options
klopez4212 87ebbf4
Filter hidden harnesses from remaining pickers
klopez4212 4ad4ee7
Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…
klopez4212 26ca6e0
Filter hidden runtimes from welcome readiness
klopez4212 d9c2b08
Preserve hidden Welcome runtime aliases
klopez4212 f62fb40
Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…
klopez4212 1f634af
Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…
klopez4212 eb015bc
Handle hidden runtimes during Welcome kickoff
klopez4212 c77ad4f
Respect hidden harnesses during onboarding
klopez4212 1e70b78
Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…
klopez4212 33a0a60
Align hidden harness fallback readiness
klopez4212 44b276f
Merge remote-tracking branch 'origin/main' into kennylopez-agent-harn…
klopez4212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
desktop/src-tauri/src/managed_agents/discovery/tests/provisioning_overrides.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| use super::{create_time_agent_command_override, persona_with_runtime}; | ||
|
|
||
| #[test] | ||
| fn preserves_deliberate_override_of_installed_runtime() { | ||
| let personas = vec![persona_with_runtime("p1", Some("claude"))]; | ||
| assert_eq!( | ||
| create_time_agent_command_override(Some("p1"), &personas, Some("codex-acp"), true), | ||
| Some("codex-acp".to_string()) | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn pins_visible_fallback_for_runtime_less_persona() { | ||
| let personas = vec![persona_with_runtime("p1", None)]; | ||
| assert_eq!( | ||
| create_time_agent_command_override(Some("p1"), &personas, Some("goose"), true), | ||
| Some("goose".to_string()) | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a runtime-less persona is provisioned with a deliberate harness override that differs from the global preferred runtime—for example, a channel template explicitly assigns Goose while Buzz Agent is preferred—both
record.runtimeand the persona runtime remain unset, so this comparison classifies the explicit pin as an implicit fallback and discards global model/provider defaults.useApplyTemplatedoes not persist the global provider and may omit the model, leaving the created agent unconfigured even though masking is intended only for implicit fallbacks; persist the selection's intent or another durable fallback marker instead of inferring it solely from a command mismatch.AGENTS.md reference: desktop/src/features/agents/AGENTS.md:L93-L99
Useful? React with 👍 / 👎.