Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix masking of sensitive environment variables - #258

Merged
bobdivx merged 2 commits into
mainfrom
sentinel/fix-mask-sensitive-env-key-3312430554577362301
Oct 22, 2026
Merged

bobdivx merged 2 commits into
mainfrom
sentinel/fix-mask-sensitive-env-key-3312430554577362301

Conversation

@bobdivx

@bobdivx bobdivx commented Oct 21, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The mask_sensitive_env_key function in crates/runner/src/docker.rs was not properly masking environment variables that contained sensitive keywords (like AWS_SECRET_ACCESS_KEY) because it only checked for exact matches or suffix matches (e.g., ends with _SECRET). This left prefixed or infixed secrets exposed.
🎯 Impact: Variables containing critical security tokens or keys could be exposed via docker inspection API or logs.
πŸ”§ Fix: Updated the function to use substring matching (upper.contains(n)) for sensitive keywords, ensuring any variable with SECRET, TOKEN, PASSWORD, etc., is masked regardless of its prefix or suffix. Also logged the vulnerability and learning in .jules/sentinel.md.
βœ… Verification: Ran cargo test in crates/runner and all 5 tests passed successfully.


PR created automatically by Jules for task 3312430554577362301 started by @bobdivx

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@bobdivx
bobdivx merged commit c7fcbe6 into main Oct 22, 2026
4 checks passed
@bobdivx
bobdivx deleted the sentinel/fix-mask-sensitive-env-key-3312430554577362301 branch October 22, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant