🛡️ Sentinel: [CRITICAL] Fix masking of sensitive environment variables

.jules/sentinel.md

@@ -2,6 +2,11 @@
 **Vulnerability:** The manual SVG sanitizer `apps/web/src/lib/sanitize-svg.ts` used an insufficient allowlist/blocklist. It allowed `<foreignObject>`, `<use>`, `<animate>`, `<set>`, `<image>`, and `<math>` which could lead to mutation XSS (mXSS) and other attack vectors when rendering untrusted Mermaid or Math blocks.
 **Learning:** Manual DOM tree sanitization is notoriously hard to get right because attackers can hide active elements (e.g. `<a>` tags with `javascript:` payloads) inside grandchild trees (like `<math><mtext><a>`) or use SVG-specific tricks (like `<animate href... values="javascript:...">`) which naive list-based cleaners overlook.
 **Prevention:** Rather than adding heavy third-party dependencies (like DOMPurify) against explicit project instructions, expanding the `BLOCKED` Set to include these structural injection vectors provides a robust, zero-dependency mitigation. Future expansions should verify nested elements carefully.
+## 2023-10-25 - [Fix Masking of Secrets in Environment Variables]
+**Vulnerability:** The `mask_sensitive_env_key` function in `docker.rs` was not properly masking environment variables that contained sensitive keywords (like `AWS_SECRET_ACCESS_KEY`) because it only checked for exact matches or suffix matches (e.g., ends with `_SECRET`).
+**Learning:** Only matching for suffixes or exact values can leave secrets exposed when developers prefix or infix the sensitive word in the environment variable name.
+**Prevention:** Use substring matching (`contains`) for sensitive keywords to ensure all variables containing words like `SECRET` or `TOKEN` are masked.
+
 
 ## 2026-10-18 - [Timing Attack in Webhook Signature Verification]
 **Vulnerability:** The `verify_github_sig` function in `apps/server/src/infra_routes.rs` verified GitHub webhook signatures using standard string comparison `expected.eq_ignore_ascii_case(hex_sig)`.

crates/runner/src/docker.rs

@@ -486,7 +486,7 @@ pub fn mask_sensitive_env_key(key: &str) -> bool {
     let upper = key.to_uppercase();
     SENSITIVE
         .iter()
-        .any(|n| upper == *n || upper.ends_with(&format!("_{n}")))
+        .any(|n| upper.contains(n))
 }
 
 pub fn parse_inspect_env(inspect: &serde_json::Value) -> Vec<EnvEntry> {