Open
Conversation
poyenc
force-pushed
the
feature/enhance-code-coverage
branch
4 times, most recently
from
bf853cc to
04e49e3
Compare
poyenc
force-pushed
the
feature/enhance-code-coverage
branch
from
04e49e3 to
63102a7
Compare
Codecov Report
@@ Coverage Diff @@
## develop #17 +/- ##
============================================
+ Coverage 70.95% 92.92% +21.97%
============================================
Files 3 3
Lines 210 212 +2
Branches 74 66 -8
============================================
+ Hits 149 197 +48
+ Misses 18 0 -18
+ Partials 43 15 -28
Continue to review full report at Codecov.
|
aminya
suggested changes
Nov 15, 2020
aminya
left a comment
aminya
left a comment
There was a problem hiding this comment.
Could you break your changes into multiple commits? Each change should have a rational in their commit message.
The commit which adds the tests is OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of code coverage is 90%