Pull request for issue #24#25
Conversation
The progress bar for 'many2many' relational imports was not updating because the `run_write_tuple_import` function, which handles these updates, did not report its progress. This change addresses the issue by: - Passing the `progress` and `task_id` objects from `run_write_tuple_import` to the `_create_relational_records` function. - Updating `_create_relational_records` to use these objects to reset the progress bar's total and advance it for each batch of records processed. This ensures that the progress bar now accurately reflects the status of `many2many` relational imports.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
|
/gemini review |
The progress bar for 'many2many' relational imports was not updating because the `run_write_tuple_import` function, which handles these updates, did not report its progress. This change addresses the issue by: - Passing the `progress` and `task_id` objects from `run_write_tuple_import` to the `_create_relational_records` function. - Updating `_create_relational_records` to use these objects to reset the progress bar's total and advance it for each batch of records processed. This ensures that the progress bar now accurately reflects the status of `many2many` relational imports.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces progress reporting for the 'write_tuple' relational import strategy. The changes correctly add progress and task_id parameters to the relevant functions and use them to update a rich progress bar during the import process. The implementation is sound. I have one suggestion regarding the function signature to improve long-term maintainability.
1 participant
Fixes #24
PR created automatically by Jules for task 14293058778322744001