Skip to content

Pull request for issue #24 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 2 commits into from
Closed

Pull request for issue #24 #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f13d26
fix(import): Update progress bar for m2m relations
google-labs-jules[bot] Sep 25, 2025
b179a0c
fix(import): Update progress bar for m2m relations
google-labs-jules[bot] Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/odoo_data_flow/lib/relational_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,8 @@ def run_write_tuple_import(
related_model_df,
original_filename,
batch_size,
progress,
task_id,
)


Expand All @@ -525,6 +527,8 @@ def _create_relational_records(
related_model_df: pl.DataFrame,
original_filename: str,
batch_size: int,
progress: Progress,
task_id: TaskID,
Comment thread
bosd marked this conversation as resolved.
) -> bool:
"""Create records in the relational table.

Expand All @@ -546,6 +550,8 @@ def _create_relational_records(
related_model_df: DataFrame with related model IDs
original_filename: The original filename
batch_size: The batch size for processing
progress: The rich Progress object.
task_id: The TaskID for the current progress bar.

Returns:
True if successful, False otherwise
Expand Down Expand Up @@ -601,6 +607,9 @@ def _create_relational_records(
successful_updates = 0
failed_records_to_report = []

# Reset the progress bar for this specific field's updates
progress.update(task_id, total=len(grouped_data), completed=0)

# Update each owning record with its many2many field values
for owning_id, related_ids in grouped_data.items():
try:
Expand All @@ -612,6 +621,7 @@ def _create_relational_records(
# Update the owning record with the many2many field
owning_model.write([owning_id], {field: m2m_command})
successful_updates += 1
progress.update(task_id, advance=1)

except Exception as e:
log.error(
Expand Down
Loading