[WIP] fix(api): make API→runner TLS verification configurable#773
Conversation
The internal API→runner proxy hop hard-coded `secure: false`, disabling TLS certificate verification. The hop is Bearer-authenticated but lacks integrity/MITM protection. Make it driven by BOXLITE_RUNNER_TLS_VERIFY, defaulting to the prior behavior (disabled) so runners with internal/self-signed certs are not broken, and allowing operators with verifiable runner certs to opt in. [WIP] NOT verified locally: requires building/running the NestJS API plus a runner with a verifiable TLS certificate to confirm the internal hop still works with verification enabled. No NestJS build was run in this environment. Audit finding boxlite-ai#17 (low). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
boxlite security fixes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
boxlite security fixes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Problem
The internal API→runner proxy hop hard-coded
secure: false(
boxlite-proxy.controller.ts), disabling TLS certificate verification. The hopis Bearer-authenticated but has no integrity/MITM protection.
Change
Drive
securefromBOXLITE_RUNNER_TLS_VERIFY, defaulting tofalse(priorbehavior — no breakage for runners with internal/self-signed certs), opt-in
truefor operators whose runners present a verifiable certificate.What needs a resource to verify
apps/api) — not run here.BOXLITE_RUNNER_TLS_VERIFY=true, and an e2e exec/proxy call through it.Audit finding #17 (low).
🤖 Generated with Claude Code