Skip to content

[WIP] fix(api): make API→runner TLS verification configurable #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
G4614 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] fix(api): make API→runner TLS verification configurable #773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/api/src/boxlite-rest/boxlite-proxy.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,17 @@ export class BoxliteProxyController {
throw new NotFoundException(`Runner endpoint for box ${boxId} not found`)
}

// TLS verification for the internal API→runner hop. Defaults to the prior
// behavior (disabled) so deployments whose runners present an internal /
// self-signed certificate are not broken, but can be enabled by operators
// whose runners present a verifiable certificate by setting
// BOXLITE_RUNNER_TLS_VERIFY=true. Without verification the Bearer-authed hop
// still lacks integrity/MITM protection (audit finding #17).
const verifyRunnerTls = process.env.BOXLITE_RUNNER_TLS_VERIFY === 'true'

const proxyOptions: Options = {
target: targetUrl,
secure: false,
secure: verifyRunnerTls,
changeOrigin: true,
autoRewrite: true,
ws: opts?.ws ?? false,
Expand Down
Loading