This repository was archived by the owner on Aug 2, 2026. It is now read-only.
Repository navigation
feat: GUITAR mode — octave-down front end + red theme - #25
Closed
jameshgordy wants to merge 3 commits into
Closed
jameshgordy wants to merge 3 commits into
jameshgordy wants to merge 3 commits into
Conversation
Play a guitar, get a bass: a GUITAR key on the bottom bar pitches the input down an octave ahead of the whole chain and recolors the editor red (per-instance theme — other open editors stay cyan). DSP: the granular shifter returns, generalized to a prepare-time ratio. Octave-down sweeps the taps the other way (0 -> grain, causal, no lookahead), keeps the correlation splice, drops the pre-LPF (down-shift cannot alias), and floors the tap delay at 2 samples so interpolation never reads past the write head. Latency (mean grain/2 + snap/2 + DMIN = 1538 smp @ 48 kHz) is reported only while engaged, via the restored listener/AsyncUpdater machinery — zero-latency with the mode off. The shifted signal becomes the plugin's "DI" (DI blend strip, analyzer, stack feed); the A/B key still auditions the true un-shifted input. Engage/disengage crossfades over 10 ms (same law as A/B). guitar_mode is an APVTS bool (stateVersion 4, default off = v3 byte-identical) and is excluded from the preset surface: factory reset skips it, user presets neither save nor apply it — presets are tones, this is what's plugged in. Verified: all 7 existing bor-bench fnv fingerprints byte-identical, cal deltas unchanged (<= 0.03 dB), new GUITAR fingerprint recorded and deterministic across runs (1c7847705b1de387), auval -v aufx BbEn BxRl PASS (incl. 11025/22050 Hz and state round-trip). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Closed
The Standalone hides the GUITAR key and force-bypasses the mode (wrapperType gate), whatever a loaded session says: AU/VST3/AAX only. bor-bench instantiates as wrapperType_Undefined, so the GUITAR fingerprint config still exercises the shifter — verified unchanged (1c7847705b1de387), auval PASS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
James, in Logic: the mode key belongs at the top. The bottom bar returns to FREQ + analyzer only; the update link chains off the GUITAR key when present (plugin formats), off SYS in the Standalone as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A GUITAR key on the bottom bar pitches the input down one octave ahead of the entire chain (play a guitar, get a bass) and recolors the whole editor red. Stacked on #24.
guitar_modeAPVTS bool, stateVersion 3→4 (default off = byte-identical), excluded from factory reset and user-preset save/load.Drawable::replaceColour, one repaint per toggle.Verified: 7 existing fingerprints byte-identical, cal deltas ≤ 0.03 dB, GUITAR fingerprint deterministic,
auval -v aufx BbEn BxRlPASS.🤖 Generated with Claude Code