fix: remove python3 dependency, fix version on global install#2
Merged
fix: remove python3 dependency, fix version on global install#2
Conversation
- Remove python3 os.path.relpath call from cmd_sync; use pure bash relative path (../.agents/<subdir>) which is always correct since both .agents/ and .<target>/ sit at project root - Fix --version showing 'unknown' on global npm install by falling back to node require() when the relative package.json path fails
nmccready
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
1. Remove python3 dependency from
cmd_syncThe
synccommand was shelling out topython3to compute relative paths:This is unnecessary — both
.agents/and.<target>/always sit at the project root, so the relative path is always../.agents/<subdir>. The python3 fallback was already the correct value.Impact: Works on any system with bash — no python3 required.
2. Fix
--versionon global npm installWhen installed globally (
npm install -g), the relative path topackage.json(${SCRIPT_DIR}/../../package.json) may not resolve because npm creates a bin symlink that changes the directory structure. Version was showingunknown.Now falls back to
node -p "require('@brickhouse-tech/sync-agents/package.json').version"which uses Node's module resolution to find the package regardless of install location.Testing
All 38 tests pass ✅ | shellcheck clean ✅