✨ No profiles template if no plugin#277
Open
aremery wants to merge 2 commits into
Open
Conversation
desrosj
reviewed
Sep 20, 2021
alektrefi
reviewed
Sep 22, 2021
| * @param array $page_templates list of registered page templates. | ||
| * @return array $page_templates list of registered page templates. | ||
| */ | ||
| function remove_profile_template( $page_templates ) { |
Contributor
There was a problem hiding this comment.
While it is legal to define a function inside an IF statement, I'd recommend moving the function declaration outside of the IF statement for clarity and consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266
Changes proposed in this pull request
This pull request unregisteres the profiles template if BU Profiles is not activated.