Skip to content

✨ No profiles template if no plugin #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aremery wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

✨ No profiles template if no plugin #277

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0703f
:sparkles: No profiles template if no plugin
Sep 17, 2021
8927843
:zap: Improve plugin activation check
Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions inc/profiles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,18 @@ function after_setup_theme() {
add_image_size( 'responsive_profile_large', $width, $height, $crop );
}
add_action( 'after_setup_theme', __NAMESPACE__ . '\after_setup_theme' );

if ( ! defined( 'BU_PROFILES_PLUGIN_ACTIVE' ) || ! BU_PROFILES_PLUGIN_ACTIVE ) {
/**
* Removes the profile template if BU profiles is not active.
*
* @param array $page_templates list of registered page templates.
* @return array $page_templates list of registered page templates.
*/
function remove_profile_template( $page_templates ) {
Copy link
Copy Markdown
Contributor

@alektrefi alektrefi Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is legal to define a function inside an IF statement, I'd recommend moving the function declaration outside of the IF statement for clarity and consistency.

unset( $page_templates['profiles.php'] );

return $page_templates;
}
add_filter( 'theme_page_templates', __NAMESPACE__ . '\remove_profile_template' );
}