Repository navigation
chore: move the spec pin to v0.8.0+oscal.1.2.3 - #70
Merged
Merged
Conversation
Move SPEC_ARTIFACT_VERSION and SPEC_ARTIFACT_SHA256 to the 0.8.0 release of the spec store. The regenerated models.py is unchanged. The 0.8.0 corpus adds cases for contract changes that the binding does not implement yet. List them as strict expected failures, each tied to its tracking issue (#58, #59, #61, #62, #63, #69). Mark test_every_category_is_mapped as a strict xfail until the read-error and builder-error categories are mapped. Closes #67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Changes
scripts/spec_artifact.py: pin0.8.0+oscal.1.2.3, sha2563da20cc6…8dda(matchesSHA256SUMSof the store release).hatch run generate:models.pyis unchanged, so there is no schema-driven diff and the drift check holds.tests/support/expected_failures.py, each tied to its tracking issue: Return datetime bounds from assessment_period() (FAC-007) #58 (FAC-007), Return one element-type name for each manifest type (ELV-002) #59 (ELV-002), Report the read-error category for a file-path parse that cannot read the file (ERR-012) #61 (ERR-012), Derive the resource identifier from a key and report the builder-error category (BMB-004, ERR-013) #62 (BMB-004, ERR-013), Run the facade corpus operation (FAC-001 to FAC-003) #63 (facade and builder operations), Report only failures of the selected nested-union branch (PRS-014) #69 (PRS-014, new).test_every_category_is_mappedis a strict xfail until theread-errorandbuilder-errorcategories are mapped (Report the read-error category for a file-path parse that cannot read the file (ERR-012) #61, Derive the resource identifier from a key and report the builder-error category (BMB-004, ERR-013) #62).Not done
NAM-022 (#57): not checked against the code; no test failed because of it.
Verification
hatch teston Python 3.11 and 3.14: 3349 passed, 2 skipped, 33 xfailed.hatch run lintandhatch run typingpass. Python 3.12 and 3.13 not run locally.Benchmarks
No performance change:
models.pyis identical, so no before/after numbers apply.