Skip to content

refactor(replay): move command types into replay-port - #3019

Merged
thymikee merged 2 commits into
codex/2663-replay-classificationfrom
codex/2663-replay-command-types
Sep 28, 2026
Merged

thymikee merged 2 commits into
codex/2663-replay-classificationfrom
codex/2663-replay-command-types

Conversation

@thymikee

@thymikee thymikee commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Move the replay command and daemon dependency types unchanged into @agent-device/replay-port/command-types. Replay internals and daemon handlers now import those types from the owning package. Remove the daemon replay index's superseded type reexports and their layering declarations.

This is the next dependent slice of #2663, based on #3016. Runtime behavior is unchanged; the remaining replay modules and tests will move in subsequent slices.

Validation

Live .ad and Maestro replay characterization remains for the completed package move.

@thymikee
thymikee added this pull request to stack #3020 September 28, 2026 10:54
@thymikee thymikee changed the title codex/2663 replay command types refactor(replay): move command types into replay-port Sep 28, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 32 files

Re-trigger cubic

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.87 MB 4.87 MB 0 B
Package (unpacked) 4.87 MB 4.87 MB 0 B
Package (download) 1.46 MB 1.46 MB +5 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 28.6 ms 28.8 ms +0.3 ms
CLI --help 86.7 ms 85.8 ms -1.0 ms

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstack.github.io/agent-device/pr-preview/pr-3019/

Built to branch gh-pages at 2026-09-28 17:01 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at 0fadbb9, and checked again at edbe5dc, which only rebases onto the updated #3016 and merges the package.json exports and imports the files that #3007 moved from their new place. This is a pure move: the command types go into replay-port with import-path changes only, and the removed daemon re-exports have no remaining consumers. No blocking issues.

CI: checks on edbe5dc are still running. This PR stacks on #3016, which must land first.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 28, 2026
@thymikee
thymikee force-pushed the codex/2663-replay-command-types branch from edbe5dc to 7bb96b5 Compare September 28, 2026 16:35
@thymikee
thymikee merged commit f20d241 into main Sep 28, 2026
28 of 39 checks passed
@thymikee
thymikee deleted the codex/2663-replay-command-types branch September 28, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant