refactor(move): relocate remaining daemon replay test fixtures - #3037
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 28 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Reviewed at 4c9b979. This move breaks typecheck. Not blocking: some |
|
Reviewed at 119f206. The stale import of the moved replay-command-fixture.ts is gone, so the typecheck break from the earlier review (4c9b979) is fixed. This is ready for human review. Not blocking: the comment at src/tests/test-utils/android-ui-hierarchy-fixtures.ts line 124 still points at the old path of session-replay-divergence-chrome-filter.test.ts, which now lives under src/daemon/tests/replay-divergence/. It was already stale before this PR. CI: Smoke Tests was still pending, so there is no run yet to confirm the typecheck fix. |
119f206 to
642e3ef
Compare
Summary
Move the remaining daemon-backed replay test fixtures and their mirrored suites out of
src/daemon/replay/**, preserving test topology. Daemon integration tests remain with daemon tests and pure replay tests remain package-owned. This dependent #2663 slice follows #3035 and prepares the final connected production move in #3041.Review fix
Update the iOS tap-outcome test import to the relocated replay command fixture. The previous path under
src/daemon/replay/__tests__no longer exists. The focused test first reproducedCannot find module, then passed 18/18 after the import correction.Validation
119f20655: freshpnpm install --frozen-lockfile && pnpm build && pnpm check:affected --runpassed.