Skip to content

refactor(move): relocate remaining daemon replay test fixtures - #3037

Merged
thymikee merged 2 commits into
codex/2663-replay-runtime-testsfrom
codex/2663-replay-final-tests
Sep 28, 2026
Merged

thymikee merged 2 commits into
codex/2663-replay-runtime-testsfrom
codex/2663-replay-final-tests

Conversation

@thymikee

@thymikee thymikee commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Move the remaining daemon-backed replay test fixtures and their mirrored suites out of src/daemon/replay/**, preserving test topology. Daemon integration tests remain with daemon tests and pure replay tests remain package-owned. This dependent #2663 slice follows #3035 and prepares the final connected production move in #3041.

Review fix

Update the iOS tap-outcome test import to the relocated replay command fixture. The previous path under src/daemon/replay/__tests__ no longer exists. The focused test first reproduced Cannot find module, then passed 18/18 after the import correction.

Validation

  • Exact head 119f20655: fresh pnpm install --frozen-lockfile && pnpm build && pnpm check:affected --run passed.
  • No runtime behavior changes in this layer.

@thymikee
thymikee added this pull request to stack #3020 September 28, 2026 13:05
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.87 MB 4.87 MB 0 B
Package (unpacked) 4.87 MB 4.87 MB 0 B
Package (download) 1.46 MB 1.46 MB +3 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.2 ms 26.6 ms +0.5 ms
CLI --help 77.5 ms 78.3 ms +0.8 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 28 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/daemon/__tests__/replay-runtime/replay-command-fixture.ts
@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at 4c9b979. This move breaks typecheck. src/daemon/interaction/internal/__tests__/interaction-ios-tap-outcome.test.ts line 17 still imports ../../../replay/__tests__/replay-command-fixture.ts, but this PR moves that fixture to src/daemon/__tests__/replay-runtime/replay-command-fixture.ts. This is the TS2307 error in Repo Guards, and Typecheck & Package and Coverage fail for the same reason. Please update that import, and search the whole tree for other references to the old replay/__tests__ and replay/internal/__tests__ paths.

Not blocking: some wait string literals in session-replay-target-verification-runtime.test.ts (near line 596) changed to String.raw templates. The values are the same, but the change is not part of the move.

@thymikee

Copy link
Copy Markdown
Member Author

Reviewed at 119f206. The stale import of the moved replay-command-fixture.ts is gone, so the typecheck break from the earlier review (4c9b979) is fixed. This is ready for human review.

Not blocking: the comment at src/tests/test-utils/android-ui-hierarchy-fixtures.ts line 124 still points at the old path of session-replay-divergence-chrome-filter.test.ts, which now lives under src/daemon/tests/replay-divergence/. It was already stale before this PR.

CI: Smoke Tests was still pending, so there is no run yet to confirm the typecheck fix.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 28, 2026
@thymikee
thymikee force-pushed the codex/2663-replay-final-tests branch from 119f206 to 642e3ef Compare September 28, 2026 16:35
@thymikee
thymikee merged commit 8c3ffd7 into main Sep 28, 2026
24 of 34 checks passed
@thymikee
thymikee deleted the codex/2663-replay-final-tests branch September 28, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant