refactor(move): complete replay port package extraction - #3041
Conversation
|
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 52 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Reviewed at fec8036. The move looks correct, but one fallow baseline entry did not move with its file. This PR renames Checks were still running at review time. If Repo Guards fails, check this entry first. The typecheck break from #3037 must also be fixed before this stack can go green. |
|
Reviewed at f77f9ee, following up on the earlier review at fec8036 (#3041 (comment)). The change at f77f9ee only touches src/daemon/tests/replay-coordinator-ownership.test.ts, so the baseline problem from the last round is still open. fallow-baselines/health.json:566 still keys the complexity baseline as Smoke Tests is still queued, so there's no result to attribute to this delta; the only changed file is a self-contained ownership test, not part of the device-facing smoke route it covers. Once the health.json key is moved, this is ready for human review. |
|
CI follow-up: the iOS fixture-backed Smoke Tests job 108970206222 failed at step 11 ( |
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="fallow-baselines/health.json">
<violation number="1" location="fallow-baselines/health.json:566">
P2: This line fixes the `native-command.ts` baseline but two sibling entries in the same `target_keys` list were not moved with their renames: `src/daemon/replay/internal/session-replay-heal.ts` (line 539) and `src/daemon/replay/internal/session-test-infrastructure.ts` (line 579) still key paths that no longer exist, while the files now live at `packages/replay-port/src/daemon-port/`. Since fallow baselines are path-keyed and must move on rename, update both entries to the new package paths as well.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
| "packages/capture-kit/src/snapshot/snapshot-presentation/text-surface.ts:high impact", | ||
| "src/daemon/handlers/session-test-sharding.ts:high impact", | ||
| "src/daemon/replay/internal/native-command.ts:complexity", | ||
| "packages/replay-port/src/daemon-port/native-command.ts:complexity", |
There was a problem hiding this comment.
P2: This line fixes the native-command.ts baseline but two sibling entries in the same target_keys list were not moved with their renames: src/daemon/replay/internal/session-replay-heal.ts (line 539) and src/daemon/replay/internal/session-test-infrastructure.ts (line 579) still key paths that no longer exist, while the files now live at packages/replay-port/src/daemon-port/. Since fallow baselines are path-keyed and must move on rename, update both entries to the new package paths as well.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At fallow-baselines/health.json, line 566:
<comment>This line fixes the `native-command.ts` baseline but two sibling entries in the same `target_keys` list were not moved with their renames: `src/daemon/replay/internal/session-replay-heal.ts` (line 539) and `src/daemon/replay/internal/session-test-infrastructure.ts` (line 579) still key paths that no longer exist, while the files now live at `packages/replay-port/src/daemon-port/`. Since fallow baselines are path-keyed and must move on rename, update both entries to the new package paths as well.</comment>
<file context>
@@ -563,7 +563,7 @@
"packages/capture-kit/src/snapshot/snapshot-presentation/text-surface.ts:high impact",
"src/daemon/handlers/session-test-sharding.ts:high impact",
- "src/daemon/replay/internal/native-command.ts:complexity",
+ "packages/replay-port/src/daemon-port/native-command.ts:complexity",
"packages/platform-apple/src/core/debug-symbols/utils.ts:high impact",
"packages/platform-linux/src/snapshot.ts:high impact",
</file context>
|
Reviewed at a4badbb. The new commit moves the complexity baseline key in fallow-baselines/health.json to |
a4badbb to
199f35f
Compare
Summary
@agent-device/replay-port, route daemon callers through package exports, and removesrc/daemon/replay/**.git diff -M90%).Validation
a4badbb72: freshpnpm install --frozen-lockfile && pnpm build && pnpm format && pnpm check:affected --runpassed, including related tests, package checks, Maestro conformance, and wire compatibility.a4badbb72: recorded.adreplay passed 2/2 steps, 0 heals; Maestro checkout form passed 17/17 steps, 0 heals. Baseline3c1f51382had the same 2/2 and 17/17 results. Both final sessions closed; session list and device claims are empty.