Repository navigation
test(audit): 9 fewer tests in ios, leasing, dispatcher and http, since 19a11eb - #1086
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed.
Comment |
Contributor
Author
Review findings, round 1 (commit 63277e3)Assessment: complete. Lenses: code/tests (Opus), claims (Sonnet); spec skipped (no issue). Removed-test coverage checked: no unique coverage lost.
Written by an agent. |
V3RON
marked this pull request as ready for review
October 30, 2026 16:56
V3RON
added a commit
that referenced
this pull request
Oct 30, 2026
… since 19a11eb (#1039) Range: `19a11eb..6316e10`, first half of the audit; the ios, leasing, dispatcher and http files moved to #1086 to stay under the 1,500-line cap. Tests only; source untouched. **Files:** src/cli/index, src/daemon/main, src/daemon/server, src/agent-device/edge, src/updater/index, src/spec-lint, ui/src/state/queries, src/drivers/android/input/device-input. Left for the next run: the other 153 changed test files. **Test counts (before -> after):** cli 384->380, daemon/main 151->149, daemon/server 137->133, edge 229->225, updater 31->32; queries, spec-lint, device-input unchanged. Net -13. **Applied verdicts:** DELETE/MERGE/TABLE collapse duplicate or data-only tests; FIX adds an assertion proven by a temporary source break, or narrows a title. **Bug found:** two cli tests keep `not.toBe(0)`: `daemon start` reports an invalid config.json as `INTERNAL` (exit 1), not exit 2. Filed as #1084. ## Review Spec review: skipped. Code review: 0 blocking, 0 fixed, 1 note. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 1. Tokens: 6.7M. Runs: 3. Cost USD: 2.7772. Agent seconds: 1153. Assessment: complete. Notes: - code: src/daemon/server.test.ts:400 title says "renews" but checks only `ok: true`; the admin renew test and the lifecycle tests prove renewal. ## Review Spec review: skipped. Code review: 0 blocking, 0 fixed, 1 note. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 1. Tokens: 6.7M. Runs: 3. Cost USD: 2.7772. Agent seconds: 1153. Assessment: complete. Notes: - code: src/daemon/server.test.ts:400 title says "renews" but checks only `ok: true`; the admin renew test and the lifecycle tests prove renewal. *Written by an agent.* --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range:
19a11eb..6316e10, second half of the audit split out of #1039 to stay under the 1,500-line cap. Tests only; source untouched.Files: src/drivers/ios/index, src/leasing/create-leasing, src/gateway/dispatcher, src/http/app.
Test counts (before -> after): ios 195->193, create-leasing 184->183, http/app 180->172, dispatcher 91->93. Net -9.
Applied verdicts: DELETE/MERGE/TABLE collapse duplicate or data-only tests; FIX adds an assertion proven by a temporary source break, or narrows a title. The
supportsPersistentSlimunit test is kept, so its export (and the source) stay as on main.Review
Spec review: skipped. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: 4.7M.
Runs: 5. Cost USD: 2.1054. Agent seconds: 951.
Assessment: complete.
Written by an agent.