Skip to content

fix(e2e): the drain test answers the Fleet page without the host's load (#886) - #938

Merged
V3RON merged 1 commit into
mainfrom
bug/886
Oct 23, 2026
Merged

V3RON merged 1 commit into
mainfrom
bug/886

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

The drain test in e2e/console/actions.spec.ts read the host's real disk usage. A disk at 95% or more outranks "drained" in the Fleet row, so on such a machine the row never read "drained". The test now answers the workers list without the load reading, as six Fleet tests in workers.spec.ts already do.

Status

Implement: done (1/1 green) Review: round 1 passed Hardware: n/a Gate: ready

  • A host with a full disk no longer fails "a worker is drained from Fleet with no dialog, and Undo undrains it" (answerWithoutLoad(page) before openPage, e2e/console/actions.spec.ts). Checked: code review round 1, 3/3 passes on a 97%-full disk, and the test fails with the line removed.

Assumptions

none

Proof: with the triage line forcing a 98% disk (branch bug/886-repro, not in this PR) the test fails at toContainText("drained") (row shows disk 98%); with the one-line fix after it, the test passes. Without the repro line, the drain test passes on this machine.

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 1.6M.
Runs: 6. Cost USD: 0.9814. Agent seconds: 1248.

Assessment: complete

Closes #886

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 23, 2026 16:10
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 9eca808

Runs: 6. Cost USD: 0.9814. Agent seconds: 1248.
Tokens input 122, output 19036, cache read 1427193, cache write 194334.
- build 1 implementer: claude-sonnet-5-5 384 s $0.1901
- implement 1 implementer none: claude-sonnet-5-5 243 s $0.1263
- review 1 reviewer none: claude-sonnet-5-5 320 s $0.164
- review 1 spec: claude-sonnet-5-5 14 s $0.0692
- review 1 code both: claude-opus-5-5 243 s $0.3244
- review 1 claims: claude-sonnet-5-5 44 s $0.1074
Finding outcomes: {}. Classes: {}.
{"findings":[]}

Written by an agent.

@V3RON
V3RON merged commit cfa43df into main Oct 23, 2026
79 of 80 checks passed
@V3RON
V3RON deleted the bug/886 branch October 23, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console e2e: a worker is drained from Fleet with no dialog, and Undo undrains it fails on the row's drained text

1 participant