Skip to content

fix(e2e): the drain test answers the Fleet page without the host's load (#886) #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V3RON merged 1 commit into from
Oct 23, 2026
Merged

fix(e2e): the drain test answers the Fleet page without the host's load (#886) #938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions e2e/console/actions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
startFleet,
test,
} from "./fixtures.js";
import { answerWithoutLoad } from "./workers-answers.js";

const ONE_DEVICE = { limits: { ios: { maxDevices: 1, maxRunning: 1 }, maxRunning: 1 } };
const IOS = { availableOsVersions: ["18.4"], knownModels: ["iPhone 16"] };
Expand Down Expand Up @@ -166,6 +167,8 @@ test.describe("the console acts", () => {
test("a worker is drained from Fleet with no dialog, and Undo undrains it", async ({ page }) => {
const fleet = await startFleet([{ driverScript: { ios: IOS }, label: "drain-a" }]);
try {
// why: the row shows the host's own disk and CPU; one over its limit outranks "drained" (#886).
await answerWithoutLoad(page);
await openPage(page, fleet.gateway, "/fleet", "Fleet");
const row = rowOf(page, "drain-a");
await expect(row).toBeVisible();
Expand Down
Loading