fix(kubeflow-dashboard-links): correct interface schema requirer - #663
Open
james-garner-canonical wants to merge 2 commits into
Open
Conversation
…terface schema The schema declared the requirer's application databag as a bare list of dashboard items. A Juju databag is always a mapping, and the library (`charms.kubeflow_dashboard.v0.kubeflow_dashboard_links`) writes the list JSON-encoded under a `dashboard_links` key. The schema now says that, which also makes it usable with `ops.Relation.load`. The interface README still shows the bare list, and should be updated to match. Alongside this, the schema moves to the new format: models are named directly as `ProviderAppData`, `ProviderUnitData`, `RequirerAppData` and `RequirerUnitData` rather than wrapped in `pytest-interface-tester` classes, with `None` for a databag that is always empty. A follow-up PR documents the format and adds a CI check for it, once every interface has been migrated. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
james-garner-canonical
marked this pull request as ready for review
September 3, 2026 06:01
james-garner-canonical
force-pushed
the
26-08+chore+interface-schemas-mlops
branch
from
September 11, 2026 03:10
fafc6fa to
a900aa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema declared the requirer's application databag as a bare list of dashboard items. A Juju databag is always a mapping, and the library (
charms.kubeflow_dashboard.v0.kubeflow_dashboard_links) writes the list JSON-encoded under adashboard_linkskey. The schema now says that, which also makes it usable withops.Relation.load. The README hsa been updated to reflect this.Alongside this, the schema moves to the new format: models are named directly as
ProviderAppData,ProviderUnitData,RequirerAppDataandRequirerUnitDatarather than wrapped inpytest-interface-testerclasses, withNonefor a databag that is always empty.A follow up PR will document the new format and add tooling to enforce it, after similar PRs have landed for all the other
CODEOWNERSin this repository.