Skip to content

fix(kubeflow-dashboard-links): correct interface schema requirer #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-garner-canonical wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(kubeflow-dashboard-links): correct interface schema requirer #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
054fdb0
fix(kubeflow-dashboard-links): correct the requirer databag in the in…
james-garner-canonical Aug 31, 2026
a900aa7
docs: correct readme
james-garner-canonical Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions interfaces/kubeflow_dashboard_links/interface/v0/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ The requirer specifies zero or more sidebar items in the required format.

#### Example

The `dashboard_links` key might contain the following as a JSON-encoded string:

```json
[
{
Expand Down
20 changes: 13 additions & 7 deletions interfaces/kubeflow_dashboard_links/interface/v0/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
"""This file defines the schemas for the provider and requirer sides of the kubeflow-dashboard-links interface.

Examples:
RequirerSchema:
Requirer:
unit: <empty>
app: [
app: {
"dashboard_links": '[
{
"text": "Some link text",
"link": "/some-relative-link",
Expand All @@ -14,10 +15,10 @@
"icon": "assessment",
"desc": "link description"
}
]
]'
}
"""

from interface_tester.schema_base import DataBagSchema
from pydantic import BaseModel


Expand Down Expand Up @@ -45,7 +46,12 @@ class DashboardItem(BaseModel):
desc: str = ""


class RequirerSchema(DataBagSchema):
"""Requirer schema for Ingress."""
class RequirerAppData(BaseModel):
"""The requirer's application databag."""

app: list[DashboardItem]
dashboard_links: list[DashboardItem]


ProviderAppData = None
ProviderUnitData = None
RequirerUnitData = None
Loading