fix(interfaces-oauth): update lib to reconcile oauth clients holistically - #678
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates charmlibs-interfaces-oauth to backport changes from
charms.hydra.v0.oauth.Summary of changes in
charmlibs-interfaces-oauth1. Core Library
• Added
OAuthProvider.get_client_config()andget_client_secret()helper methods.• Updated
OAuthProvider._create_juju_secret()to update existing secrets via set_content() instead of re-adding them.• Updated secret lookups to use
refresh=Trueso rotated secret revisions aren't stale.• Wrapped databag parsing in try ... except DataValidationError to log warnings rather than crashing hooks on incomplete data.
2. Documentation & Exports
• Updated the module docstring to add the Provider reference documentation for
OAuthProvider.get_client_config().3. Versioning & Release Notes
• _version.py: Bumped version to 1.1.0.
• CHANGELOG.md: Added release notes entry for 1.1.0.
4. Unit Tests (tests/unit/test_oauth_provider.py)
• Added tests for
get_client_config(),get_client_secret(), updating existing secret content, and handling invalid relation data.