feat: Sigma rules pt.3 - #197
Merged
Merged
Conversation
This was referenced May 8, 2026
Draft
MichaelThamm
commented
Jun 25, 2026
| tags = sigma.rules[0]["tags"] | ||
| assert "juju_model_uuid.deadbeef" in tags | ||
| assert not any( | ||
| tag.startswith("juju_model_uuid.") and tag != "juju_model_uuid.deadbeef" for tag in tags |
Contributor
Author
There was a problem hiding this comment.
update name deadbeef
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We need to test the feature for confidence that it works.
Solution
Add testing for Sigma rules using Pytest-bdd. With some reference Sigma rules, we have an idea of what the rules look like and can assert against them in the tests.
Builds on:
Checklist
project.versionfield in thepyproject.tomlfile.Context
Testing Instructions
Upgrade Notes