fix: handle multiple istio-ingress-route relations - #214
Merged
NohaIhab merged 4 commits intoJun 23, 2026
Merged
Conversation
Use model.relations[...] (a list) instead of model.get_relation(...) when checking ambient vs. sidecar ingress, so envoy no longer raises TooManyRelatedAppsError when more than one istio-ingress-route relation is present. Add unit and integration coverage for multiple ambient ingress relations and widen the metallb CIDR so the integration tests can deploy a second Istio ingress gateway.
Assert every istio-ingress-route relation receives a valid HTTPRoute config.
🤖 Backport labels populatedLabels to this pull request were added automatically by the When the PR is merged, backport PRs according to the labels will be automatically created. To skip the backport creation, remove any unneeded labels before merging the PR. |
MattiaSarti
requested changes
Jun 19, 2026
MattiaSarti
left a comment
MattiaSarti
left a comment
Contributor
There was a problem hiding this comment.
todo: shall we also add the same comment to `` before line 55 in src/components/istio_ambient_requirer_component.py, as done for the other pull requests?
# submit_config publishes this same config to every istio-ingress-route
# relation, so all related ingress providers are (re)configured at once.
self.ingress.submit_config(self._istio_ingress_route_config)
MattiaSarti
approved these changes
Jun 22, 2026
dariofaccin
approved these changes
Jun 22, 2026
NohaIhab
deleted the
kf-8750-handle-multiple-istio-ingress-route-relations
branch
June 23, 2026 07:31
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of canonical/bundle-kubeflow#1446
Use
model.relations[...]instead ofmodel.get_relation(...)when checking ingress relations, so the charm no longer raisesTooManyRelatedAppsErrorwhen more than oneistio-ingress-routerelation is present.Add unit tests covering multiple
istio-ingress-routerelations and verifying each relation receives a validHTTPRouteconfig.Note: this PR was created with the help of AI