fix: handle multiple istio-ingress-route relations (backport #214) - #215
Merged
Merged
Conversation
* fix: handle multiple istio-ingress-route relations Use model.relations[...] (a list) instead of model.get_relation(...) when checking ambient vs. sidecar ingress, so envoy no longer raises TooManyRelatedAppsError when more than one istio-ingress-route relation is present. Add unit and integration coverage for multiple ambient ingress relations and widen the metallb CIDR so the integration tests can deploy a second Istio ingress gateway. * test: strengthen istio-ingress-route unit tests Assert every istio-ingress-route relation receives a valid HTTPRoute config. * test: verify web-grpc mlmd access before and after second ingress (cherry picked from commit c88457d)
NohaIhab
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #214 to
track/2.4.