[DPE-7882] fix(logical-replication): block cyclic subscription requests (4/5) - #269
Draft
marceloneppel wants to merge 1 commit into
Draft
[DPE-7882] fix(logical-replication): block cyclic subscription requests (4/5)#269marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
2 tasks
…ts (4/5) The subscriber side now rejects its own circular setups before the request reaches the publisher: subscribing to a table this app already publishes to the same remote, and subscribing to a table whose remote replication chain already contains this app, both fail validation with a dedicated blocked status. Publisher errors reported on the relation are re-validated against the current subscription request, so stale errors no longer block the relation processing, and genuine circular rejections surface the specific status message. Fixes canonical/postgresql-operator#1085
marceloneppel
force-pushed
the
lr-3-circular-chains
branch
from
September 4, 2026 21:51
af15795 to
2256e5f
Compare
marceloneppel
force-pushed
the
lr-4-circular-validation
branch
from
September 4, 2026 21:51
6e55d8e to
9d7aaf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fourth PR of the logical replication migration series (after #268). Completes the fix for canonical/postgresql-operator#1085: configuring the same table on both sides of the relation previously set up cyclic replication and an infinite loop of inserts; it must instead fail validation with a blocked status.
Solution
Subscriber-side rejection of its own circular setups, before the request reaches the publisher:
_check_subscriber_circular_replication),_would_create_circular_replication, multi-hop safe),Circular replication detected ...blocked statuses via_fail_validation(status_msg=...).Publisher errors reported on the relation are re-validated against the current subscription request, so stale errors no longer block relation processing, and genuine circular rejections keep the specific status message.
Checklist