Skip to content

NUT-XX: Mint Quote Lookup by Public Key#1834

Open
TheMhv wants to merge 4 commits into
cashubtc:mainfrom
TheMhv:feat/mint_quote_lookup
Open

NUT-XX: Mint Quote Lookup by Public Key#1834
TheMhv wants to merge 4 commits into
cashubtc:mainfrom
TheMhv:feat/mint_quote_lookup

Conversation

@TheMhv
Copy link
Copy Markdown
Contributor

@TheMhv TheMhv commented Apr 3, 2026

Description

The CDK implementation of NUT-XX: Mint Quote Lookup by Public Key

Closes: #1746


Notes to the reviewers

  • Create a new route for mint quote /mint/quote/{method}/pubkey
  • Create a new get_mint_quotes_by_pubkey database function and add your test
  • Create a migration to add index into pubkey from mint_quote table in Database
  • Create the struct for Request defined in NUT

Suggested CHANGELOG Updates

CHANGED

ADDED

  • A new NUT file nuts/nutxx.rs
  • A new route v1/mint/quote/{method}/pubkey
  • Migrations for add index to pubkey field in mint_quote table

REMOVED

FIXED


Checklist

@github-project-automation github-project-automation Bot moved this to Backlog in CDK Apr 3, 2026
@TheMhv TheMhv changed the title NUT-XX: Mint Quote Lookup by Public Key (WIP) NUT-XX: Mint Quote Lookup by Public Key Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2026

Codecov Report

❌ Patch coverage is 0% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.99%. Comparing base (73500ef) to head (9731898).

Files with missing lines Patch % Lines
crates/cdk/src/mint/issue/mod.rs 0.00% 52 Missing ⚠️
crates/cdk-common/src/database/mint/test/mint.rs 0.00% 33 Missing ⚠️
crates/cdk-axum/src/custom_handlers.rs 0.00% 21 Missing ⚠️
crates/cdk-sql-common/src/mint/quotes.rs 0.00% 5 Missing ⚠️
crates/cdk-axum/src/custom_router.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   65.12%   64.99%   -0.14%     
==========================================
  Files         329      329              
  Lines       56711    56825     +114     
==========================================
- Hits        36934    36933       -1     
- Misses      19777    19892     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread crates/cashu/src/nuts/nutxx.rs Outdated
Comment thread crates/cashu/src/nuts/nutxx.rs Outdated
Comment thread crates/cdk-sql-common/src/mint/quotes.rs
Comment thread crates/cdk-sql-common/src/mint/quotes.rs
Comment thread crates/cdk-sql-common/src/mint/quotes.rs
@github-project-automation github-project-automation Bot moved this from Backlog to In progress in CDK Apr 4, 2026
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup branch 2 times, most recently from 6869944 to 4797303 Compare April 5, 2026 14:50
Comment thread crates/cdk-common/src/mint.rs
Comment thread crates/cdk-axum/src/custom_handlers.rs
Comment thread crates/cashu/src/nuts/nutxx.rs Outdated
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup branch 3 times, most recently from 900c85a to 0a811de Compare April 6, 2026 15:09
@thesimplekid thesimplekid self-requested a review April 8, 2026 15:46
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup branch 3 times, most recently from bf90e64 to c19a25f Compare April 23, 2026 18:16
@TheMhv TheMhv force-pushed the feat/mint_quote_lookup branch from c19a25f to 7e6b290 Compare April 28, 2026 13:08
@TheMhv TheMhv marked this pull request as ready for review April 28, 2026 14:48
@TheMhv TheMhv changed the title (WIP) NUT-XX: Mint Quote Lookup by Public Key NUT-XX: Mint Quote Lookup by Public Key Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

New Nut: Implement get quotes by pubkeys

2 participants