feat: add NUT-29 batch minting error codes#366
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds two new NUT-29 batch minting validation error codes (duplicate quote IDs and max batch size exceeded) and updates the NUT-29 spec + test vectors to reference them.
Changes:
- Added error codes
11016(duplicate quote IDs) and11017(max batch size exceeded) to the shared error code registry. - Updated
29.mdto reference the new error codes in request validation and batch size limit documentation. - Updated
tests/29-tests.mdto include the expected error code for the duplicate quote IDs test vector.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/29-tests.md | Documents expected error code 11016 for the duplicate quote IDs test vector. |
| error_codes.md | Registers new NUT-29 error codes 11016 and 11017. |
| 29.md | References the new error codes in validation rules and batch size limit notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a1denvalu3
approved these changes
Apr 24, 2026
This was referenced Apr 28, 2026
3 tasks
thesimplekid
force-pushed
the
nut_29_error_codes
branch
from
86e5683 to
c8f4bb3
Compare
thesimplekid
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two error codes for NUT-29 batch minting validation failures that have no existing coverage.
11016 Duplicate quote IDs provided: quote IDs are a distinct entity from proof inputs (11007) and blinded outputs (11008). The NUT-29 spec explicitly mandates uniqueness in validation rule 2 and29-tests.mdhas a test vector for this failure path.11017 Max batch size exceeded: covers the max_batch_size enforcement path. Same family as11014 (max inputs)and11015 (max outputs). Identified as missing during CTS NUT-29 implementation.Both codes follow the 110xx structural validation family numbering.
Changes
29.mdvalidation rules and batch size section to reference the new codes.29-tests.mdwith expected error code for the duplicate quotes test vector.