refactor(qr): QR 生成画面を金額・受取先・設定・プレビューの節に分割し URL 導出は親に残す (R11b) - #618
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
第 6 回レビュー Phase 6 の R11b (F14)。1,425 行の QrGenerator を 691 行にし、金額・受取先・ 設定・プレビュー・要約の節と download helper を components/qr/ に移す (原本の行範囲を そのまま写し、字下げと export 以外は同一)。hydration・支払い URL/EIP-681/gas の導出・ 着金監視・前回 QR の保存・qrRef・プレビューの modal と印刷/download は親に残す。 支払い URL の完全一致 fixture (宛先・金額・chain・gas・分割・FX・cross-chain の opt-out) と 節ごとの DOM・再描画での同一性を旧実装で固定した。 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HeizmagJBgL5peL5mQpxkc
cipherwebllc
force-pushed
the
fix/r6-r11b-qr-generator
branch
from
September 24, 2026 10:38
e808f7c to
b0bf91e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
第 6 回レビュー Phase 6 (完全リファクタ) の R11b です (指摘 F14)。挙動を変えない抽出だけです。
1,425 行の
QrGenerator(支払い QR の作成画面) を 691 行にし、表示の節をcomponents/qr/に移します。QrAmountSection.tsxQrReceiverSection.tsxQrSettingsSection.tsxQrPreviewSection.tsx(下部 bar・空状態を含む)QrSummaries.tsxqrDownload.tsexport以外は同一です。原本の 1,425 行はすべて行き先を確認しています。qrRef、プレビューの modal と印刷/download、すべての状態。公開文言・DOM・生成する支払い URL・localStorage は変わりません。
固定と検証 (base = main に rebase 済み)
既存の挙動 (本 PR では変えない・B-R11d)
🤖 Generated with Claude Code
https://claude.ai/code/session_01HeizmagJBgL5peL5mQpxkc