Skip to content

Add a delimiter between two hashes#190

Open
jsf9k wants to merge 1 commit intodevelopfrom
bugfix/add-delimiter-between-hashes
Open

Add a delimiter between two hashes#190
jsf9k wants to merge 1 commit intodevelopfrom
bugfix/add-delimiter-between-hashes

Conversation

@jsf9k
Copy link
Copy Markdown
Member

@jsf9k jsf9k commented May 5, 2026

🗣 Description

This pull request adds a - delimiter between two hashes.

💭 Motivation and context

Previously the hash for requirements.txt was concatenated directly with the hash for pyproject.toml. This can increase the chance of ambiguous cache keys and makes the key harder to read/compare with the other jobs (which use a - separator).

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Previously the hash for requirements.txt was concatenated directly
with the hash for pyproject.toml.  This can increase the chance of
ambiguous cache keys and makes the key harder to read/compare with the
other jobs (which use a - separator).
@jsf9k jsf9k self-assigned this May 5, 2026
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels May 5, 2026
@jsf9k jsf9k moved this to In Progress in Next Kraken May 5, 2026
@github-actions github-actions Bot added the github-actions Pull requests that update GitHub Actions code label May 5, 2026
@jsf9k jsf9k marked this pull request as ready for review May 5, 2026 14:22
Copilot AI review requested due to automatic review settings May 5, 2026 14:22
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners May 5, 2026 14:22
@jsf9k jsf9k moved this from In progress to Review in progress in Skeleton Maintenance May 5, 2026
@jsf9k jsf9k requested a review from a team May 5, 2026 14:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the test-source workflow cache key consistent with the other jobs by inserting a - separator between the requirements.txt hash and the pyproject.toml hash. In the broader workflow configuration, this reduces cache-key ambiguity and aligns formatting across Python job caches.

Changes:

  • Add a missing - delimiter in the test-source job’s actions/cache key.
  • Align the test-source cache key structure with the existing cache key patterns used elsewhere in build.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release

Projects

Status: In Progress
Status: Review in progress

Development

Successfully merging this pull request may close these issues.

3 participants