Skip to content

Deploy jobs use GitHub environments - #51

Merged
byteful merged 1 commit into
mainfrom
chore/deploy-environments
Oct 5, 2026
Merged

byteful merged 1 commit into
mainfrom
chore/deploy-environments

Conversation

@byteful

@byteful byteful commented Oct 5, 2026

Copy link
Copy Markdown
Member

What changed

The admin deploy job now runs inside the GitHub staging / production environment. A production deploy waits for approval by a release reviewer and can only run from main or a release tag. No admin UI changes.

Before you start

Verify

[Admin]

  1. Open the "Deploy (Cloudflare Pages)" run started by the merge — Expect: the job shows the environment "staging", starts without waiting, and finishes green.
  2. Open admin.civfix.dev and sign in — Expect: the dashboard loads as before.
  3. In Actions, open "Deploy (Cloudflare Pages)" → "Run workflow", pick any branch other than main, run it — Expect: the job is refused before any step runs, with a message that the branch is not allowed to deploy to "staging".

Regression

Production release — [Admin]

  1. At the next release, open the release run of "Deploy (Cloudflare Pages)" — Expect: it shows "Waiting" for review in "production"; after approval it deploys admin.civfix.org.

Not covered

  • The production approval itself until the next release.
  • Release tags cut before this merge have no environment in their workflow and are not gated (secrets stay repo-level by decision).

@byteful
byteful merged commit c63857b into main Oct 5, 2026
1 check passed
@byteful
byteful deleted the chore/deploy-environments branch October 5, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant