Fix deb build to use correct Docker build arg name#239
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix broken Debian packages for some distributions
Fix parallel matrix builds overwriting each other's output directories
Jan 16, 2026
baelter
force-pushed
the
copilot/fix-debian-package-dependencies
branch
from
aa552e6 to
6df88a2
Compare
baelter
changed the title
baelter
force-pushed
the
copilot/fix-debian-package-dependencies
branch
from
6df88a2 to
03a45d1
Compare
The Dockerfile.deb expects `build_image` but the workflow was passing `image`, causing all builds to use the default ubuntu-24.04 base image regardless of the target OS matrix. This resulted in all deb packages having identical sha256 hashes and wrong dependencies (libc6 >= 2.38). Also update Crystal image tag from 1.15.1 to 1.18.2, as the 1.15.1 images no longer exist on Docker Hub. Using 1.18.2 instead of latest to avoid deprecation warnings in newer Crystal versions. Fixes #238
baelter
force-pushed
the
copilot/fix-debian-package-dependencies
branch
from
03a45d1 to
7c83748
Compare
baelter
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Debian packages for all distributions had identical SHA256 hashes and wrong dependencies (e.g., Bullseye requiring
libc6 >= 2.38).Root Cause
The
Dockerfile.debexpects a build argument namedbuild_image:But the workflow was passing
imageinstead:Since the argument name didn't match, Docker used the default value (
ubuntu-24.04) for all matrix jobs, causing every deb package to be built against Ubuntu 24.04 regardless of the target distribution.Fix
imagetobuild_imageto match the Dockerfile's expected argument name1.15.1to1.18.2(the 1.15.1 images no longer exist on Docker Hub; using 1.18.2 instead oflatestto avoid deprecation warnings in newer Crystal versions)Fixes #238