Repository navigation
chore: upgrade actions to Node 24 runtime (SHA-pinned) - #2934
Conversation
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
Dependency ReviewThe following issues were found:
License Issues.github/workflows/test.yml
Scanned Files
|
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflow references to eliminate remaining Node 20–runtime action usage by bumping SHA-pinned reusable workflow refs from cloudposse/.github and upgrading golangci/golangci-lint-action to a Node 24–compatible release, aligning with the repository’s SHA-pinning convention.
Changes:
- Re-pin
cloudposse/.githubreusable workflow calls to a newermaincommit SHA across release-related workflows. - Upgrade
golangci/golangci-lint-actionfromv8.0.0tov9.3.0(SHA-pinned) in the CodeQL workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test.yml | Updates reusable workflow pin for push-triggered release job. |
| .github/workflows/nightlybuilds.yml | Updates reusable workflow pin for nightly release job. |
| .github/workflows/feature-release.yml | Updates reusable workflow pin for label-triggered feature release job. |
| .github/workflows/codeql.yml | Upgrades golangci-lint action to a newer SHA-pinned version. |
| .github/workflows/build.yml | Updates reusable workflow pin for release-branches workflow call. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates shared release workflow pins, the CodeQL lint action version, and the GoReleaser configuration. ChangesRelease and workflow updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR updates pinned GitHub Actions and shared workflow references to newer Node 24-compatible revisions. No actionable merge-blocking risk remains beyond normal checks. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Follow-up (e1ca674): migrated |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
- Coverage 83.28% 83.26% -0.02%
==========================================
Files 1898 1898
Lines 185012 185012
==========================================
- Hits 154090 154058 -32
- Misses 23078 23105 +27
- Partials 7844 7849 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
e1ca674 to
62838dc
Compare
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
Tip Atmos Pro
No affected stacks workflow was detected for this pull request. |
|
These changes were released in v1.226.0-test.9. |
…into 1199-pro-exec-metadata * '1199-pro-exec-metadata' of github.com:cloudposse/atmos: chore: upgrade actions to Node 24 runtime (SHA-pinned) (#2934) fix(docker): build the arm64 image with an arm64 userland (#2932) feat(profiles): interactive multi-select for bare --profile (#2951) fix(git): tolerate config errors for CI git-clone bootstrap pre-Cobra (#2879) feat(vendor): add --stack/--labels flags, fix --tags selector bugs (#1889) feat(scaffold): dynamic per-combination file generation via matrix (#2928) feat(auth): add GKE kubeconfig integration (#2937)
what
golangci/golangci-lint-action@4afd733a # v8.0.0→@ba0d7d2e...# v9.3.0— safe here sincethe workflow uses
install-mode: nonewith a custom-built golangci-lint from a Nov-2025 (v2-era)commit, which v9 supports
cloudposse/.githubshared-workflow refs (shared-go-auto-release.yml,shared-release-branches.yml) from8244c7c9 # mainto current main49ac8cd5 # main— the oldpin predates chore: upgrade actions to Node 24 runtime and enforce SHA pinning .github#261, so release workflows were still running node20 action
versions from the stale snapshot
why
to
runs.using: node20verify-sha-pinningtest suite passes (28/28) over the modified tree, and actionlint is cleanreferences
still on Node 20
bobheadxi/deployments@648679e8 # v1— latest release is still node20; no node24 version to pinhttps://github.com/bobheadxi/deployments
cloudposse/github-action-seek-deployment@9c18326d # 0.1.1— node20; runtime bump tracked inUpgrade action runtime to Node 24 github-action-seek-deployment#29 (needs a maintainer with push access)