Skip to content

chore: upgrade actions to Node 24 runtime (SHA-pinned) - #2934

Merged
Erik Osterman (Cloud Posse) (osterman) merged 4 commits into
mainfrom
chore/node24-runtime-upgrade
Aug 18, 2026
Merged

Erik Osterman (Cloud Posse) (osterman) merged 4 commits into
mainfrom
chore/node24-runtime-upgrade

Conversation

@johncblandii

@johncblandii John C. Bland II (johncblandii) commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

what

  • Bump the last node20-era action pin to Node 24, SHA-pinned per this repo's convention:
    • golangci/golangci-lint-action@4afd733a # v8.0.0 → @ba0d7d2e... # v9.3.0 — safe here since
      the workflow uses install-mode: none with a custom-built golangci-lint from a Nov-2025 (v2-era)
      commit, which v9 supports
  • Re-pin the cloudposse/.github shared-workflow refs (shared-go-auto-release.yml,
    shared-release-branches.yml) from 8244c7c9 # main to current main 49ac8cd5 # main — the old
    pin predates chore: upgrade actions to Node 24 runtime and enforce SHA pinning .github#261, so release workflows were still running node20 action
    versions from the stale snapshot

why

  • GitHub is deprecating the Node 20 runtime; these were the remaining refs in this repo resolving
    to runs.using: node20
  • Verified: every changed SHA matches its upstream tag / branch head, this repo's own
    verify-sha-pinning test suite passes (28/28) over the modified tree, and actionlint is clean

references

still on Node 20

Copilot AI lite review requested due to automatic review settings August 13, 2026 17:00
@johncblandii John C. Bland II (johncblandii) added the no-release Do not create a new release (wait for additional code changes) label Aug 13, 2026
@atmos-pro

atmos-pro Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@github-actions

Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/test.yml

PackageVersionLicenseIssue Type
cloudposse/.github/.github/workflows/shared-go-auto-release.yml49ac8cd5c4cf74abdbf24a80027cd3bde811133aNullUnknown License
Allowed Licenses: MIT, MIT-0, Apache-2.0, BSD-2-Clause, BSD-2-Clause-Views, BSD-3-Clause, ISC, MPL-2.0, 0BSD, Unlicense, CC0-1.0, CC-BY-3.0, CC-BY-4.0, CC-BY-SA-3.0, Python-2.0, OFL-1.1, LicenseRef-scancode-generic-cla, LicenseRef-scancode-unknown-license-reference, LicenseRef-scancode-unicode, LicenseRef-scancode-google-patent-license-golang
Excluded from license check: pkg:golang/github.com/antlr4-go/antlr/v4, pkg:golang/github.com/google/cel-go, pkg:golang/golang.org/x/image, pkg:golang/modernc.org/libc, pkg:golang/github.com/opencontainers/go-digest, pkg:npm/pako, pkg:npm/sax

Scanned Files

  • .github/workflows/test.yml

@mergify

mergify Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify Bot added the needs-cloudposse Needs Cloud Posse assistance label Aug 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflow references to eliminate remaining Node 20–runtime action usage by bumping SHA-pinned reusable workflow refs from cloudposse/.github and upgrading golangci/golangci-lint-action to a Node 24–compatible release, aligning with the repository’s SHA-pinning convention.

Changes:

  • Re-pin cloudposse/.github reusable workflow calls to a newer main commit SHA across release-related workflows.
  • Upgrade golangci/golangci-lint-action from v8.0.0 to v9.3.0 (SHA-pinned) in the CodeQL workflow.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/test.yml Updates reusable workflow pin for push-triggered release job.
.github/workflows/nightlybuilds.yml Updates reusable workflow pin for nightly release job.
.github/workflows/feature-release.yml Updates reusable workflow pin for label-triggered feature release job.
.github/workflows/codeql.yml Upgrades golangci-lint action to a newer SHA-pinned version.
.github/workflows/build.yml Updates reusable workflow pin for release-branches workflow call.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/test.yml Resolved
@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 87a23ddb-2274-46a3-ab23-5d75c6622f0f

📥 Commits

Reviewing files that changed from the base of the PR and between e1ca674 and 95c14e1.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

📝 Walkthrough

Walkthrough

The pull request updates shared release workflow pins, the CodeQL lint action version, and the GoReleaser configuration.

Changes

Release and workflow updates

Layer / File(s) Summary
Release workflow revisions
.github/workflows/build.yml, .github/workflows/feature-release.yml, .github/workflows/nightlybuilds.yml, .github/workflows/test.yml, .github/actions/verify-sha-pinning/README.md
Release jobs and documentation now reference the shared Go auto-release workflow at commit 49ac8cd5c4cf74abdbf24a80027cd3bde811133a.
GoReleaser configuration
.goreleaser.yml
The configuration declares version 2 and uses formats: [binary] for archives.
CodeQL lint action update
.github/workflows/codeql.yml
The workflow now uses golangci/golangci-lint-action version v9.3.0.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 95c14

The PR updates pinned GitHub Actions and shared workflow references to newer Node 24-compatible revisions. No actionable merge-blocking risk remains beyond normal checks.

Possibly related PRs

Suggested reviewers: aknysh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: upgrading GitHub Actions to Node 24 with SHA-pinned references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/node24-runtime-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 13, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 13, 2026
@johncblandii

Copy link
Copy Markdown
Contributor Author

Follow-up (e1ca674): migrated .goreleaser.yml to the GoReleaser v2 schema (version: 2, archives[].formats) and validated with goreleaser check v2.17.1. Context: shared-go-auto-release.yml (via cloudposse/.github#261) now installs GoReleaser v2 through goreleaser-action v7's version: latest, and v2 rejects configs without a version: 2 key — this would have failed the next atmos release. The org fallback config gets the same migration in cloudposse/.github#267.

@codecov

codecov Bot commented Aug 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.26%. Comparing base (6f30e1a) to head (95c14e1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2934      +/-   ##
==========================================
- Coverage   83.28%   83.26%   -0.02%     
==========================================
  Files        1898     1898              
  Lines      185012   185012              
==========================================
- Hits       154090   154058      -32     
- Misses      23078    23105      +27     
- Partials     7844     7849       +5     
Flag Coverage Δ
unittests 83.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@atmos-pro

atmos-pro Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

Merged via the queue into main with commit 498c376 Aug 18, 2026
83 checks passed
@atmos-pro

atmos-pro Bot commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Tip

Atmos Pro  

No affected stacks workflow was detected for this pull request.
If this is expected, no action is needed.
Learn More. Ask AI.

@osterman
Erik Osterman (Cloud Posse) (osterman) deleted the chore/node24-runtime-upgrade branch August 18, 2026 21:32
@mergify mergify Bot removed the needs-cloudposse Needs Cloud Posse assistance label Aug 18, 2026
@github-actions

Copy link
Copy Markdown

These changes were released in v1.226.0-test.9.

Igor Rodionov (goruha) added a commit that referenced this pull request Aug 18, 2026
…into 1199-pro-exec-metadata

* '1199-pro-exec-metadata' of github.com:cloudposse/atmos:
  chore: upgrade actions to Node 24 runtime (SHA-pinned) (#2934)
  fix(docker): build the arm64 image with an arm64 userland (#2932)
  feat(profiles): interactive multi-select for bare --profile (#2951)
  fix(git): tolerate config errors for CI git-clone bootstrap pre-Cobra (#2879)
  feat(vendor): add --stack/--labels flags, fix --tags selector bugs (#1889)
  feat(scaffold): dynamic per-combination file generation via matrix (#2928)
  feat(auth): add GKE kubeconfig integration (#2937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Do not create a new release (wait for additional code changes) size/s Small size PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants