Support Container config with union types and intersection types#287
Merged
Support Container config with union types and intersection types#287
Container config with union types and intersection types#287Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for advanced PHP type features in the Container configuration, specifically union types (PHP 8.0+), intersection types (PHP 8.1+), and DNF (Disjunctive Normal Form) types (PHP 8.2+). This enhancement allows factory functions to use these modern type hints for better type safety and flexibility, particularly useful for environment variable resolution.
Key Changes:
- Refactored
Container::validateType()to recursively handle union, intersection, and DNF types instead of rejecting them - Updated error messages to be more descriptive when type mismatches occur
- Added comprehensive test coverage for all new type features
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Container.php | Removed early abort for union/intersection types; enhanced validateType() to recursively check complex types; updated typeName() to handle non-named types |
| tests/ContainerTest.php | Added new tests for union, intersection, and DNF types; updated existing test names and error message expectations to reflect new behavior |
| tests/AppTest.php | Updated error messages for invalid constructor types to match new error format |
| docs/best-practices/controllers.md | Updated documentation to clarify that environment variables are strings and may require union types or casting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0e62ac8 to
b15fbcc
Compare
This was referenced Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for
Containerconfig with union types (PHP 8.0+) and intersection types (PHP 8.1+) and DNF types (PHP 8.2+). With these changes applied, factory functions may now explicitly use advanced type features introduced in recent PHP versions, which is especially useful forstringenvironment variable resolution:Note that this does not affect default autowiring if no explicit factory function is used. This includes a number of updated tests to verify correct behavior and avoid introducing any potential regressions, so this has 100% code coverage and should be safe to apply. On top of this, I've updated the documentation slightly to emphasize environment variables are always of type
stringcurrently. This is the next step in adding better configuration support and support for environment variables and.env(dotenv) files as discussed in #101.Builds on top of #286, #284, #184, #92, and others