fix(web): sandbox copy works on HTTP/intranet#67
Merged
Conversation
navigator.clipboard is unavailable in non-secure contexts; add copyToClipboard with execCommand fallback and surface copy failures via toast in SandboxListView and SandboxConsoleView. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copyToClipboardhelper: secure context prefers Clipboard API; non-secure (HTTP/intranet) skips API and uses textarea +execCommand('copy')in the same gesture stack; returnsPromise<boolean>without throwing.SandboxListView(detail proxy URL / ENDPOINTS / copy ID) andSandboxConsoleView(copy password) to the helper: success keeps inline「已复制」; failure shows Toastcommon.toast.copyFailed(复制失败 / Copy failed)— no silent catch.Coverage (this PR only):
SandboxListView+SandboxConsoleView. Out of scope (unchanged):ArtifactPreview,PmLeaderChat,WorkflowApiTab,AgentStudioView.Test plan
npm test -- --run src/lib/copyToClipboard.test.ts(6 cases green)http://内网IP, click detail「复制」on proxy path andhost:port— clipboard gets text, button shows「已复制」Made with Cursor