fix(tts): advance continuous reading by section index#429
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Analysis
readerTab.chapterIndexis written fromRelocateDetail.section.current, so it represents the foliate spine/section index. The old TTS fallback treated that value as an index intotocItems. For books whose TOC has volume parent nodes, the next TOC item can be a volume such as "第二卷" rather than the next readable chapter, so reading "第一章" could jump into the wrong volume.This change makes the TTS fallback and TTS chapter controls use
goToIndex(sectionIndex)with section bounds from relocate/book metadata. The TOC tree remains only for user-facing table-of-contents jumps.Fixes #421
Verification
git diff --checkpnpm --filter app exec tsc --noEmitpnpm exec biome format --write packages/app/src/components/reader/ReaderView.tsxKnown baseline:
pnpm exec biome check packages/app/src/components/reader/ReaderView.tsxstill reports existing ReaderView lint diagnostics unrelated to this fix (for example historical non-null assertion, forEach, and hook dependency warnings). Formatter output was applied.