fix(sync): clarify WebDAV sync folder scope#443
Open
codedogQBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
Issue #355 is caused by a mismatch between user expectations and the intended WebDAV sync model. The sync remote folder is a ReadAny-owned bidirectional sync directory and is not a library import path. Users who already have books in WebDAV should use the WebDAV import flow instead of pointing sync at the WebDAV root.
Changes
syncRemoteRootDescin all settings locales.Verification
node -e "for (const f of ['en','zh','zh-TW','ja','ko','fr','es']) JSON.parse(require('fs').readFileSync('packages/core/src/i18n/locales/'+f+'/settings.json','utf8')); console.log('settings locale JSON ok')"git diff --checkpnpm --filter @readany/core exec tsc --noEmitpnpm --filter app exec tsc --noEmitpnpm --filter @readany/app-expo exec tsc --noEmitFixes #355