Detect locally modified skills and warn users during install - #6
Merged
Merged
Conversation
Before writing SKILL.md files to .ade/skills/, check if an existing file differs from the default content. If it does, skip overwriting and warn the user that their modified version will be used, with instructions to remove .ade/skills/ to restore defaults. Also moves writeInlineSkills() to be called at the top level in setup/install commands (like installSkills) so the return value can drive user-facing clack warnings. https://claude.ai/code/session_01Sf3uGYRodvenEj8NWyzVcM
- Add writeInlineSkills to @codemcp/ade-harnesses mock in setup/install specs - Update claude-code.spec.ts to test writeInlineSkills directly rather than via claudeCodeWriter.install(), reflecting the move of skill writing responsibility to the CLI commands https://claude.ai/code/session_01Sf3uGYRodvenEj8NWyzVcM
mrsimpson
force-pushed
the
claude/improve-local-skills-handling-6DTbE
branch
from
March 18, 2026 12:21
e4b22f0 to
a273a48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds detection for locally modified inline skills and prevents them from being overwritten during install/setup operations. Users are now warned when their local skill modifications would be lost, with instructions on how to update them if desired.
Key Changes
Modified
writeInlineSkills()function to return a list of skill names that have been locally modified, instead of voidUpdated install and setup commands to handle modified skills
runInstall()andrunSetup()now callwriteInlineSkills()and check for modificationsRefactored skill writing responsibility
writeInlineSkills()call fromclaudeCodeWriterinstall.tsandsetup.ts) where it's called beforeinstallSkills()writeInlineSkillsfrom harnesses package for use in CLIImplementation Details
https://claude.ai/code/session_01Sf3uGYRodvenEj8NWyzVcM