Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cli/src/commands/install.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ vi.mock("@codemcp/ade-harnesses", () => ({
"kiro",
"opencode"
]),
installSkills: vi.fn().mockResolvedValue(undefined)
installSkills: vi.fn().mockResolvedValue(undefined),
writeInlineSkills: vi.fn().mockResolvedValue([])
}));

import * as clack from "@clack/prompts";
Expand Down
12 changes: 11 additions & 1 deletion packages/cli/src/commands/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { readLockFile } from "@codemcp/ade-core";
import {
getHarnessWriter,
getHarnessIds,
installSkills
installSkills,
writeInlineSkills
} from "@codemcp/ade-harnesses";

export async function runInstall(
Expand Down Expand Up @@ -41,6 +42,15 @@ export async function runInstall(
}
}

const modifiedSkills = await writeInlineSkills(logicalConfig, projectRoot);
if (modifiedSkills.length > 0) {
clack.log.warn(
`The following skills have been locally modified and will NOT be updated:\n` +
modifiedSkills.map((s) => ` - ${s}`).join("\n") +
`\n\nTo use the latest defaults, remove .ade/skills/ and re-run install.`
);
}

await installSkills(logicalConfig.skills, projectRoot);

if (logicalConfig.knowledge_sources.length > 0) {
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/commands/setup.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ vi.mock("@codemcp/ade-harnesses", () => ({
install: vi.fn().mockResolvedValue(undefined)
}),
getHarnessIds: vi.fn().mockReturnValue(["claude-code"]),
installSkills: vi.fn().mockResolvedValue(undefined)
installSkills: vi.fn().mockResolvedValue(undefined),
writeInlineSkills: vi.fn().mockResolvedValue([])
}));

import * as clack from "@clack/prompts";
Expand Down
12 changes: 11 additions & 1 deletion packages/cli/src/commands/setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import {
import {
allHarnessWriters,
getHarnessWriter,
installSkills
installSkills,
writeInlineSkills
} from "@codemcp/ade-harnesses";

export async function runSetup(
Expand Down Expand Up @@ -162,6 +163,15 @@ export async function runSetup(
}
}

const modifiedSkills = await writeInlineSkills(logicalConfig, projectRoot);
if (modifiedSkills.length > 0) {
clack.log.warn(
`The following skills have been locally modified and will NOT be updated:\n` +
modifiedSkills.map((s) => ` - ${s}`).join("\n") +
`\n\nTo use the latest defaults, remove .ade/skills/ and re-run setup.`
);
}

await installSkills(logicalConfig.skills, projectRoot);

if (logicalConfig.knowledge_sources.length > 0) {
Expand Down
1 change: 1 addition & 0 deletions packages/harnesses/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export type { HarnessWriter } from "./types.js";
export { installSkills } from "./skills-installer.js";
export { writeInlineSkills } from "./util.js";

export { universalWriter } from "./writers/universal.js";
export { claudeCodeWriter } from "./writers/claude-code.js";
Expand Down
27 changes: 20 additions & 7 deletions packages/harnesses/src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,12 +185,14 @@ export async function writeGitHooks(
export async function writeInlineSkills(
config: LogicalConfig,
projectRoot: string
): Promise<void> {
): Promise<string[]> {
const modified: string[] = [];

for (const skill of config.skills) {
if (!("body" in skill)) continue;

const skillDir = join(projectRoot, ".ade", "skills", skill.name);
await mkdir(skillDir, { recursive: true });
const skillPath = join(skillDir, "SKILL.md");

const frontmatter = [
"---",
Expand All @@ -199,10 +201,21 @@ export async function writeInlineSkills(
"---"
].join("\n");

await writeFile(
join(skillDir, "SKILL.md"),
`${frontmatter}\n\n${skill.body}\n`,
"utf-8"
);
const expected = `${frontmatter}\n\n${skill.body}\n`;

try {
const existing = await readFile(skillPath, "utf-8");
if (existing !== expected) {
modified.push(skill.name);
continue;
}
} catch {
// File doesn't exist yet — fall through to write
}

await mkdir(skillDir, { recursive: true });
await writeFile(skillPath, expected, "utf-8");
}

return modified;
}
5 changes: 3 additions & 2 deletions packages/harnesses/src/writers/claude-code.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type {
PermissionPolicy
} from "@codemcp/ade-core";
import { claudeCodeWriter } from "./claude-code.js";
import { writeInlineSkills } from "../util.js";

function autonomyPolicy(profile: AutonomyProfile): PermissionPolicy {
switch (profile) {
Expand Down Expand Up @@ -290,7 +291,7 @@ describe("claudeCodeWriter", () => {
});
});

it("writes inline SKILL.md files", async () => {
it("writes inline SKILL.md files via writeInlineSkills", async () => {
const config: LogicalConfig = {
mcp_servers: [],
instructions: [],
Expand All @@ -307,7 +308,7 @@ describe("claudeCodeWriter", () => {
setup_notes: []
};

await claudeCodeWriter.install(config, dir);
await writeInlineSkills(config, dir);

const skillMd = await readFile(
join(dir, ".ade", "skills", "tanstack-architecture", "SKILL.md"),
Expand Down
2 changes: 0 additions & 2 deletions packages/harnesses/src/writers/claude-code.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
writeJson,
writeMcpServers,
writeAgentMd,
writeInlineSkills,
writeGitHooks
} from "../util.js";
import { allowsCapability, keepsWebOnAsk } from "../permission-policy.js";
Expand All @@ -27,7 +26,6 @@ export const claudeCodeWriter: HarnessWriter = {
});

await writeClaudeSettings(config, projectRoot);
await writeInlineSkills(config, projectRoot);
await writeGitHooks(config.git_hooks, projectRoot);
}
};
Expand Down