Fix mev-boost version parsing to correctly detect full semver (e.g., v1.10.1)#183
Fix mev-boost version parsing to correctly detect full semver (e.g., v1.10.1)#183Jor-Tech wants to merge 1 commit into
Conversation
…semver (e.g. v1.10.1)
WalkthroughBoth shell scripts modified to parse semantic version numbers using three-part patterns (major.minor.patch) instead of two-part patterns. Sed commands updated to use extended regex mode for MEV-Boost version extraction and version tag parsing. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (3)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR fixes two related issues where mev-boost versions were being parsed incorrectly, causing the script to treat v1.10.1 as v1.10. As a result, EthPillar would not recognize the true latest mev-boost release, and the “View software versions” screen displayed incomplete version information.
What was fixed
update_mevboost.sh
Updated the version extraction logic to correctly parse full semantic versions (major.minor.patch).
This ensures the updater detects new releases such as v1.10.1 instead of truncating to 1.10.
ethpillar.sh
Updated the version parsing in the “View software versions” section so the installed mev-boost version is shown with the full patch version (e.g., 1.10.1).
Why this fix is needed
The previous regex only captured major.minor, which caused:
Incorrect detection of the latest release.
Incorrect display of the installed version.
Prevented proper update prompts when a new patch version was released.
Testing
Verified that both installed and latest versions correctly detect full semver format.
Confirmed the update workflow now correctly identifies v1.10.1 as the latest version.
Notes
This improves reliability of mev-boost update handling and ensures version reporting is accurate for all future semver releases.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.