Skip to content

Fix mev-boost version parsing to correctly detect full semver (e.g., v1.10.1) #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jor-Tech wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix mev-boost version parsing to correctly detect full semver (e.g., v1.10.1) #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethpillar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,7 @@ while true; do
test -f /etc/systemd/system/consensus.service && _CL=$(curl -s -X GET "${API_BN_ENDPOINT}/eth/v1/node/version" -H "accept: application/json" | jq -r '.data.version')
test -f /etc/systemd/system/execution.service && _EL=$(curl -s -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"web3_clientVersion","params":[],"id":2}' "${EL_RPC_ENDPOINT}" | jq -r '.result')
[[ $EL == "Erigon-Caplin" ]] && _CL=$(curl -s -X GET "${API_BN_ENDPOINT}/eth/v1/node/version" -H "accept: application/json" | jq -r '.data.version')
_MB=$(if [[ -f /etc/systemd/system/mevboost.service ]]; then printf "Mev-boost: $(mev-boost --version 2>&1 | sed 's/.*\s\([0-9]*\.[0-9]*\).*/\1/')"; else printf "Mev-boost: Not Installed"; fi)
_MB=$(if [[ -f /etc/systemd/system/mevboost.service ]]; then printf "Mev-boost: $(mev-boost --version 2>&1 | sed -E 's/.*([0-9]+\.[0-9]+\.[0-9]+).*/\1/')"; else printf "Mev-boost: Not Installed"; fi)
if [[ -z $_CL ]] ; then
_CL="Not installed or still starting up."
fi
Expand Down
4 changes: 2 additions & 2 deletions update_mevboost.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function getCurrentVersion(){
#Find version in format #.#.#
if [[ $INSTALLED ]] ; then
# shellcheck disable=SC2001
VERSION=$(echo "$INSTALLED" | sed 's/.*\s\([0-9]*\.[0-9]*\).*/\1/')
VERSION=$(echo "$INSTALLED" | sed -E 's/.*([0-9]+\.[0-9]+\.[0-9]+).*/\1/')
else
VERSION="Client not installed."
fi
Expand Down Expand Up @@ -82,7 +82,7 @@ function promptViewLogs(){
function getLatestVersion(){
TAG_URL="https://api.github.com/repos/flashbots/mev-boost/releases/latest"
#Get tag name and remove leading 'v'
TAG=$(curl -s $TAG_URL | jq -r .tag_name | sed 's/.*v\([0-9]*\.[0-9]*\).*/\1/')
TAG=$(curl -s $TAG_URL | jq -r .tag_name | sed -E 's/.*([0-9]+\.[0-9]+\.[0-9]+).*/\1/')
# Exit in case of null tag
[[ -z $TAG ]] || [[ $TAG == "null" ]] && echo "ERROR: Couldn't find the latest version tag" && exit 1
CHANGES_URL="https://github.com/flashbots/mev-boost/releases"
Expand Down