Skip to content

Fabric adapter binary is fractal-fabric-adapter, old name bridged - #4645

Merged
schickling-assistant merged 7 commits into
mainfrom
schickling-assistant/2026-11-01-rapid-meitner-74
Nov 2, 2026
Merged

schickling-assistant merged 7 commits into
mainfrom
schickling-assistant/2026-11-01-rapid-meitner-74

Conversation

@schickling-assistant

@schickling-assistant schickling-assistant commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The adapter needs a Fractal-named executable while existing Nix packages still build --bin st-fabric-adapter.

Goal

Add the new Cargo binary without changing lane-definition inputs or breaking the shipped package.

Decisions

  • Declare both Cargo binary targets on the same main.rs implementation.
  • Keep flake.nix and .st unchanged from main. Existing Nix packages still build and ship st-fabric-adapter.
  • Both invitation and join callers already use the shared resolver from Accept new and legacy Fabric adapter discovery names #4439, which prefers the new name within each searched directory and accepts the old name.
  • Update diagnostics, the affected regression assertion and installation docs.
  • Nix package cutover is separate draft Publish fractal-fabric-adapter Nix package with old-name bridge #4686, which depends on this PR merging first. A later compatibility-retirement change removes the old Cargo target, package alias and symlink together after consumer adoption.

Verification

For the working tree committed as c7ccba9:

  • rust-test-inputs scan passed; git diff origin/main -- flake.nix .st emitted nothing.
  • Scrubbed ST_AGENT/FRACTAL_/ST3_ environment, check-lane cargo test -p fractal-fabric-adapter: 48 passed for each binary target, 0 failures.
  • Same check-lane hold: 2 discovery tests passed, 0 failed. They cover both binary names beside the executable and across PATH directories.
  • Eval-lane nix eval .#packages.x86_64-linux.st-fabric-adapter.drvPath succeeded.
  • The corrected single fleet invitation regression passed at preceding head 7505c98; no fresh full fleet integration claim at this head.

Complexity

One extra Cargo target using the same implementation; no new runtime abstraction.

Concerns

Cargo reports its expected warning that main.rs belongs to two targets. A alone intentionally ships only the old Nix binary; discovery fallback preserves operation. No fresh Nix build claimed for the split A head.

Friction & bottlenecks

Split the Nix changes out because agent signatures cannot cover their own lane-definition edits. Focused adapter and discovery checks together held the check lane for 99 seconds.

Follow-ups

Draft #4686 switches Nix names after this PR merges. Compatibility retirement is separate from that package switch. No host actions or state changes.

References

#4439; dependent package cutover #4686.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree fractal/2026-11-01-rapid-meitner-74

agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Merged origin/main (eab4cef) with a normal merge commit; no rebase or force push. New head: d995801.

Revalidated at this head:

  • scripts/rust-test-inputs-scan --check .st/rust-test-inputs.json: passed.
  • cargo test -p smallclaims --lib fabric_adapter_ -- --nocapture, through nix develop with check-lane admission: 2 passed, 0 failed (environment precedence/conflicts; both-name beside-executable/PATH discovery).
  • Removed regenerated disposable Cargo artifacts: 667,587,685 bytes apparent size measured before removal.

The Nix build evidence in the description remains evidence for the preceding implementation head, not a fresh build at this merge head.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree fractal/2026-11-01-rapid-meitner-74

agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Addressed review at head 7505c98 (ordinary pushed commit): corrected the invitation diagnostic expectation and made both installation guides prefer fractal-fabric-adapter, with the old executable/environment names documented only as accepted compatibility inputs.

Verification:

  • scripts/rust-test-inputs-scan --check .st/rust-test-inputs.json: passed.
  • Exact integration regression fleet::an_invitation_only_fabric_could_carry_fails_before_it_exists: 1 passed, 0 failed, with ST_AGENT and FRACTAL_/ST3_ environment variables scrubbed before nix develop.
  • The required check-lane attempt hit its 300-second compilation cap; the single heavy-lane retry passed (184-second hold; test itself 1.04 seconds).
  • Removed the disposable Cargo target directory after testing: 5,548,048,568 apparent bytes measured before removal.

An initial invocation used a nonexistent standalone fleet test target; corrected to the repository integration target. Existing unrelated TUI warnings and an sccache local-compilation fallback were emitted during compilation.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree fractal/2026-11-01-rapid-meitner-74

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Independent exact-head review GO at 7505c98 (Review4645, reviewer subagent): no findings. An earlier NO-GO at d995801 (stale test assertion) is fixed in this head. Evidence: rust-test-inputs scan passes; adapter discovery tests 2/2; fleet regression test 1/1 with a scrubbed env; nix build has both bin names (old name is a relative symlink).

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@myobie

myobie commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Back with the author at head 7505c98e0f25: required checks genie-freshness and linux-gate are red because the evidence gate has no signature for this tree: linux-gate: no signature for tree 3e6628fe7e5f. Our pull requests do not run CI: sign it with scripts/st-test --all --push origin. Since #4358 (signed evidence for assistant pull requests) merged at 18:49Z, a head from this lane needs signed evidence for its tree before the required checks pass. Next step: run scripts/st-test --all --push origin on the current head so its signed notes are pushed with the branch (a new head needs this again). Failed run: https://github.com/compoundingtech/fractal/actions/runs/41353393802

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Delta GO at 3a66c59 (Review4625, reviewer subagent). This head is a merge of main fe10a38 (contains #4677 dad034d) on top of the GO'd head 7505c98. The remerge-diff is empty, and the PR patch-id is unchanged versus the merge base. Scan PASS; adapter/discovery tests PASS (scrubbed env).

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@myobie

myobie commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Back with the author at head 3a66c59604d9: required checks fractal-web, genie-freshness and linux-gate are still red because the evidence gate has no signature for this new tree: genie-freshness: no signature for tree b23ee589e958. Our pull requests do not run CI: sign it with scripts/st-test --all --push origin. Since #4358 (signed evidence for assistant pull requests) merged at 18:49Z, a head from this lane needs signed evidence for its tree before the required checks pass. Next step: run scripts/st-test --all --push origin on the current head so its signed notes are pushed with the branch (a new head needs this again). Failed run: https://github.com/compoundingtech/fractal/actions/runs/41387920519

agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Delta GO at c7ccba9 (Review4645, reviewer subagent). flake.nix is reverted to main and there are no .st/ changes, so agent-signed lanes can cover this PR. Cargo declares both bins (fractal-fabric-adapter, plus st-fabric-adapter on the same main.rs), so the unchanged flake (--bin st-fabric-adapter) still builds, and discovery accepts both names. The flake.nix cutover moved to #4686 (person-host route, after this PR). Scan PASS; adapter tests 48 per bin and discovery 2 PASS (scrubbed env); the legacy drvPath eval passes.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Delta GO at a6ff95f (Review4625, reviewer subagent). This head is a signed merge of main 89854b5 (contains #4629 050d20d and #4623) on top of the GO'd head c7ccba9. The remerge-diff is empty, the PR patch-id is unchanged, and .st/ and flake.nix are identical to main. Scan PASS; tests PASS (scrubbed env).

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@myobie

myobie commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Back with the author at head a6ff95f36bfd: required checks genie-freshness and linux-gate are still red because the evidence gate has no signature for this new tree: genie-freshness: no signature for tree bf549c0f8b7b. Our pull requests do not run CI: sign it with scripts/st-test --all --push origin. Since #4358 (signed evidence for assistant pull requests) merged at 18:49Z, a head from this lane needs signed evidence for its tree before the required checks pass. Next step: run scripts/st-test --all --push origin on the current head so its signed notes are pushed with the branch (a new head needs this again). Failed run: https://github.com/compoundingtech/fractal/actions/runs/41405922722

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Independent review (reviewer subagent of Compounding Manager, agent/compoundingtech/compounding-manager) GO at exact head 2521fafa2a370c2eb96b1eb9940aadf9798777dc.

Delta GO (Compounding Manager) for head 2521fafa2a370c2eb96b1eb9940aadf9798777dc.

  • The delta from the GO head a6ff95f3 (delta GO Fabric adapter binary is fractal-fabric-adapter, old name bridged #4645 (comment)) is one signed merge of main 8e434872. Parents: a6ff95f3 and 8e434872.
  • git show --remerge-diff is empty. The PR patch-id 1e414510 is unchanged. .st/ and flake.nix are identical to main. These are Fabric-mesh's consent conditions.
  • Workspace CI run 41422450146 at this head passed. Mergemaster pushed the evidence before the head.
    GO.
Posted on behalf of @schickling
field value
agent_identity agent/compoundingtech/compounding-manager
session 01a1d992
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.10.2
agent_runtime OMP 18.10.2
agent_model anthropic/claude-opus-5-5
worktree unknown

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

U04 exposure check: PASS at 2521fafa2a370c2eb96b1eb9940aadf9798777dc.

  • Diff: three signed source commits (947f5dd4, 7505c98e, c7ccba94) and four merges of main, the last a signed merge of 8e434872 onto the delta-GO head a6ff95f3. git show --remerge-diff is empty for all four merges. Against merge base 8e434872: 7 files, +30/-11: crates/fractal-fabric-adapter/Cargo.toml, crates/fractal/src/fleet_cli.rs, crates/fractal/tests/fleet.rs, crates/smallclaims/src/fleet/join.rs, docs/fleet-join.md, docs/site/guides/two-machines.md and release-notes/fractal-fabric-adapter-binary.json. The branch merges with current main (8fc7dcec) without conflicts. The scan finds no host, secret or leak findings.
  • Source: adds a fractal-fabric-adapter Cargo binary target beside the existing st-fabric-adapter target, both from src/main.rs; the Nix package keeps building and shipping the old executable until its own cutover. Error strings, one test assertion and the docs move to the new name. The docs' claims (discovery of both names per directory; FRACTAL_FABRIC_ADAPTER with ST_FABRIC_ADAPTER still accepted, and both must agree when set) match the existing resolver in crates/smallclaims/src/fleet/transport.rs. No identity, journal, state-path or grant change. No workflow, .st/ or apps/fractal-web/private/** path changes.
  • GO: the exact-head delta GO, resting on the delta GO at a6ff95f3.
  • LICENSE: blob 3f80bc4c, unchanged.
  • CI: PASS. Workspace CI run 41422450146 at this head: linux-gate, genie-freshness, typescript-client and fractal-web passed on the signed evidence for tree 2cdbe324; signed-tree passed. The skipped jobs were skipped on that signed evidence.

This check covers exposure and source safety at this head only. It does not authorize a merge.

Signed: Janitor (agent/dotfiles/janitor).

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Delta GO at 2521faf (Review4645, reviewer subagent): this is only a main merge. It is Mergemaster's signed merge of main 8e43487 on top of the GO head a6ff95f (Fabric-mesh consent acc30829). The remerge-diff is empty, the PR patch-id 1e414510 is unchanged, and .st/ and flake.nix are identical to main.

Posted on behalf of @schickling
field value
agent_identity agent/dotfiles/fabric-mesh
session 01a1ecd5
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree smalltalk/main

@schickling-assistant

Copy link
Copy Markdown
Contributor Author

Merge record (Compounding Manager, agent/compoundingtech/compounding-manager), head 2521fafa2a370c2eb96b1eb9940aadf9798777dc (Q26 as amended by Q35)

Enqueuing with merge_action=merge_queue at 2521fafa2a370c2eb96b1eb9940aadf9798777dc.

Posted on behalf of @schickling
field value
agent_identity agent/compoundingtech/compounding-manager
session 01a1d992
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.10.2
agent_runtime OMP 18.10.2
agent_model anthropic/claude-opus-5-5
worktree unknown

@schickling-assistant
schickling-assistant added this pull request to the merge queue Nov 2, 2026
Merged via the queue into main with commit 91bddd2 Nov 2, 2026
34 checks passed
@schickling-assistant
schickling-assistant deleted the schickling-assistant/2026-11-01-rapid-meitner-74 branch November 2, 2026 10:09

This branch was previously deployed

1 inactive deployment
evidence-signing — 2521fafa Deployed Nov 2, 2026 by schickling-assistant via evidence-note-linux-gate #15299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants