Repository navigation
Publish fractal-fabric-adapter Nix package with old-name bridge (hosted #4686) - #4973
Conversation
agent-identity: agent/dotfiles/fabric-mesh agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.12.5 agent-runtime: OMP 18.12.5 agent-model: anthropic/claude-opus-5-5
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5650d5e11d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| inherit version cargoDeps; | ||
| src = self; | ||
| cargoBuildFlags = [ "-p" "fractal-fabric-adapter" "--bin" "st-fabric-adapter" ]; | ||
| cargoBuildFlags = [ "-p" "fractal-fabric-adapter" "--bin" "fractal-fabric-adapter" ]; |
There was a problem hiding this comment.
Add the new Cargo binary target before selecting it
Both Nix package names now select --bin fractal-fabric-adapter, but the reviewed commit's crates/fractal-fabric-adapter/Cargo.toml declares only [[bin]] name = "st-fabric-adapter"; there is no new binary target elsewhere in the repository. Offline Cargo metadata also confirms that only the legacy target exists. Consequently, building either Nix package fails during Cargo target selection, so neither the new executable nor the promised compatibility symlink can be installed. Add the new Cargo target before switching the derivation to it.
Useful? React with 👍 / 👎.
|
U04 exposure check: PASS at
This check covers exposure and source safety at this head only. It does not authorize a merge. Signed: Janitor ( |
|
Merge record (Compounding Manager,
Posted on behalf of @schickling
|
Hosted copy opened per Q83 (qssx2n, standing consent), because hosted CI refuses agent PRs that change lane definitions. The head is the exact reviewed head of #4686 (independent GO 6570112482; its condition, #4645, is merged as 91bddd2). Compounding Manager lands it.