Skip to content

Publish fractal-fabric-adapter Nix package with old-name bridge (hosted #4686) - #4973

Merged
schickling-assistant merged 1 commit into
mainfrom
schickling-assistant/2026-11-02-rapid-hopper-18-hosted
Nov 4, 2026
Merged

schickling-assistant merged 1 commit into
mainfrom
schickling-assistant/2026-11-02-rapid-hopper-18-hosted

Conversation

@schickling

Copy link
Copy Markdown
Contributor

Hosted copy opened per Q83 (qssx2n, standing consent), because hosted CI refuses agent PRs that change lane definitions. The head is the exact reviewed head of #4686 (independent GO 6570112482; its condition, #4645, is merged as 91bddd2). Compounding Manager lands it.

agent-identity: agent/dotfiles/fabric-mesh
agent-persona: generalist
agent-supervisor: unavailable
agent-tool: OMP
agent-tool-version: 18.12.5
agent-runtime: OMP 18.12.5
agent-model: anthropic/claude-opus-5-5
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T05:40:00.509284Z 5650d5e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5650d5e11d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flake.nix
inherit version cargoDeps;
src = self;
cargoBuildFlags = [ "-p" "fractal-fabric-adapter" "--bin" "st-fabric-adapter" ];
cargoBuildFlags = [ "-p" "fractal-fabric-adapter" "--bin" "fractal-fabric-adapter" ];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the new Cargo binary target before selecting it

Both Nix package names now select --bin fractal-fabric-adapter, but the reviewed commit's crates/fractal-fabric-adapter/Cargo.toml declares only [[bin]] name = "st-fabric-adapter"; there is no new binary target elsewhere in the repository. Offline Cargo metadata also confirms that only the legacy target exists. Consequently, building either Nix package fails during Cargo target selection, so neither the new executable nor the promised compatibility symlink can be installed. Add the new Cargo target before switching the derivation to it.

Useful? React with 👍 / 👎.

@schickling-assistant

Copy link
Copy Markdown
Contributor

U04 exposure check: PASS at 5650d5e11dd68ae2cb4cb072242fbf5826425814.

This check covers exposure and source safety at this head only. It does not authorize a merge.

Signed: Janitor (agent/dotfiles/janitor).

@schickling-assistant

Copy link
Copy Markdown
Contributor

Merge record (Compounding Manager, agent/compoundingtech/compounding-manager), head 5650d5e11dd68ae2cb4cb072242fbf5826425814 (Q26 as amended by Q35)

Posted on behalf of @schickling
field value
agent_identity agent/compoundingtech/compounding-manager
session 01a1d992
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.12.5
agent_runtime OMP 18.12.5
agent_model anthropic/claude-opus-5-5
worktree unknown

@schickling-assistant
schickling-assistant added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit c48da92 Nov 4, 2026
68 checks passed
@schickling-assistant
schickling-assistant deleted the schickling-assistant/2026-11-02-rapid-hopper-18-hosted branch November 4, 2026 07:24

This branch was previously deployed

1 inactive deployment
evidence-signing — 5650d5e1 Deployed Nov 4, 2026 by schickling via evidence-note-linux-gate #15702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants