Skip to content

Publish fractal-fabric-adapter Nix package with old-name bridge (hosted #4686) #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schickling-assistant merged 1 commit into from
Nov 4, 2026
Merged

Publish fractal-fabric-adapter Nix package with old-name bridge (hosted #4686) #4973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -739,19 +739,23 @@
};
};

stFabricAdapter = pkgs.rustPlatform.buildRustPackage {
pname = "st-fabric-adapter";
fractalFabricAdapter = pkgs.rustPlatform.buildRustPackage {
pname = "fractal-fabric-adapter";
inherit version cargoDeps;
src = self;
cargoBuildFlags = [ "-p" "fractal-fabric-adapter" "--bin" "st-fabric-adapter" ];
cargoBuildFlags = [ "-p" "fractal-fabric-adapter" "--bin" "fractal-fabric-adapter" ];

@chatgpt-codex-connector chatgpt-codex-connector Bot Nov 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the new Cargo binary target before selecting it

Both Nix package names now select --bin fractal-fabric-adapter, but the reviewed commit's crates/fractal-fabric-adapter/Cargo.toml declares only [[bin]] name = "st-fabric-adapter"; there is no new binary target elsewhere in the repository. Offline Cargo metadata also confirms that only the legacy target exists. Consequently, building either Nix package fails during Cargo target selection, so neither the new executable nor the promised compatibility symlink can be installed. Add the new Cargo target before switching the derivation to it.

Useful? React with 👍 / 👎.

nativeBuildInputs = pkgs.lib.optionals pkgs.stdenv.hostPlatform.isLinux [ pkgs.mold ];
# The shared daemon check runs the adapter's Rust tests.
doCheck = false;
# One-release bridge for pinned consumers of the old package and binary.
postInstall = ''
ln -s fractal-fabric-adapter "$out/bin/st-fabric-adapter"
'';
meta = {
description = "External Fractal fleet to Fabric runtime-peers adapter";
homepage = "https://github.com/compoundingtech/fractal";
license = pkgs.lib.licenses.mit;
mainProgram = "st-fabric-adapter";
mainProgram = "fractal-fabric-adapter";
};
};

Expand Down Expand Up @@ -1104,7 +1108,8 @@
packages.fractal-web = fractalWeb;
packages.fractal = fractal;
packages.st-chatgpt = stChatgpt;
packages.st-fabric-adapter = stFabricAdapter;
packages.fractal-fabric-adapter = fractalFabricAdapter;
packages.st-fabric-adapter = fractalFabricAdapter;
# Isolated bootstrap/live proofs use the exact pairing API revision.
packages.fabric-pairing = fabric.packages.${system}.default;
packages.st3-migrate = st3;
Expand Down
11 changes: 11 additions & 0 deletions release-notes/fractal-fabric-adapter-nix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"version": 1,
"summary": "Publish the Fabric adapter Nix package as fractal-fabric-adapter with a one-release legacy bridge",
"replay": {"status": "none", "detail": "No replay changes."},
"schema": {"status": "none", "detail": "No stored-state changes."},
"rules": {"status": "none", "detail": "No checkpoint rule changes."},
"compatibility": {"status": "changed", "detail": "packages.fractal-fabric-adapter is primary; packages.st-fabric-adapter names the same derivation. bin/st-fabric-adapter is a relative symlink to fractal-fabric-adapter for one release. Both Cargo binary targets remain available."},
"downtime": {"status": "none", "detail": "No service activation or state migration."},
"manual": {"status": "none", "detail": "Existing Nix consumers continue to work; new consumers can select the new package and executable names."},
"recovery": {"status": "none", "detail": "Identity and adapter journals are unchanged."}
}
Loading