[schickling-assistant]

Problem

req: template targets that begin with a valid target prefix, such as requirements.md#<ID> or APP-<ID>, are truncated at < and emitted as real dangling references (requirements.md# and APP-). This leaves placeholder examples in the typed graph even though fully angle-bracketed examples are excluded.

Goal

Reject an entire req: target whenever the parsed target prefix is immediately followed by an angle-bracket placeholder.

Decisions

Keep the existing target grammar and make placeholder rejection explicit at its boundary. This avoids admitting angle brackets into real targets and avoids special-casing individual template spellings.

Verification

$ LIBRARY_PATH=/nix/store/...-libiconv-115.100.1/lib cargo test --test intent_check graph_json_recognizes_all_supported_requirement_definition_forms -- --exact
running 1 test
test graph_json_recognizes_all_supported_requirement_definition_forms ... ok
test result: ok. 1 passed; 0 failed

The fixture now contains both req: requirements.md#<ID> and req: APP-<ID> and asserts that the only emitted req_trace is the real APP-R02 target.

Complexity

No new abstraction or dependency; one parser-boundary condition and two fixture inputs.

Concerns

None.

Friction & bottlenecks

The host linker needed the already-installed libiconv library path. No Nix or devenv command was invoked.

Follow-ups

None.

References

Follow-up to #14 review: #14 (comment)

Posted on behalf of @schickling

field	value
agent_identity	mbp2025.direct.omp.mjwjfku9
session	unknown
agent_persona	generalist
agent_supervisor	unavailable
agent_tool	OMP
agent_tool_version	18.2.11
agent_runtime	OMP 18.2.11
agent_model	openai-codex/gpt-5.6-sol
worktree	intent/2026-09-27-req-trace-placeholder-rejection
tooling_profile	dotfiles@2df08b9-dirty

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-27T10:18:37.009606Z	3cd7b59	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3cd7b591b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".