Repository navigation
Let the release-readiness gate pass on the release commit - #93
Merged
Merged
Conversation
The release pipeline runs pnpm test on Changesets' version commit before it publishes, and that commit moves package.json to 0.1.0 and consumes every pending changeset. The readiness gate asserted the pre-bump state only, so six of its checks failed there and would have stopped the 0.1.0 publish in the Verify step (reproduced by running `pnpm run version` on a copy of main and then the gate: 6 failed, 27 passed). The gate now recognizes that one state: the manifest at the prepared version AND nothing pending. Only there are the two describes that read the pending set skipped. A premature bump (0.1.0 with the set pending) and a set deleted without a bump both still fail, each pinned by a synthetic case, and the surface and certification checks run in every state, so the release still publishes exactly what the record certifies. The first changeset after the release still reds the gate, as designed. Claude-Session: https://claude.ai/code/session_01U24bnHKNxQWMxmfN7ny7w9
NSchatz
enabled auto-merge (squash)
September 25, 2026 20:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release pipeline runs
pnpm teston Changesets' version commit before it publishes. That commit movespackage.jsonto0.1.0and consumes every pending changeset, andtest/scripts/release-readiness.test.tsasserted the pre-bump state only, so it would have stopped the 0.1.0 publish in the Verify step.Repro (before this change)
On a copy of
mainat 8871a11:The change
The gate recognizes one state, the release commit: the manifest at the prepared version AND nothing pending (
isReleaseCommit). Only there are the two describes that read the pending set skipped.Proof after the change
Same simulation on this branch:
pnpm typecheck && pnpm lint && pnpm test && pnpm build && pnpm attwexits 0 on the simulated version commit (72 files, 1264 passed, 11 skipped). On the branch itself the gate file passes (34 tests).No change under
src/.https://claude.ai/code/session_01U24bnHKNxQWMxmfN7ny7w9